Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit allows inconsistent mix between tab and space indentation in JSON files #2332

Open
PromiseFru opened this issue Jan 26, 2024 · 6 comments · May be fixed by #2499
Open

pre-commit allows inconsistent mix between tab and space indentation in JSON files #2332

PromiseFru opened this issue Jan 26, 2024 · 6 comments · May be fixed by #2499
Labels
bug good-first-bug

Comments

@PromiseFru
Copy link
Collaborator

The check-json hook from pre-commit/pre-commit-hooks currently does not address the issue of inconsistent mixing between tab and space indentation within the JSON content. This can lead to potential problems, as mixing tabs and spaces for indentation is generally not recommended for JSON files.

bugbot/configs/rules.json

Lines 422 to 426 in d26e6fa

"performancebug": {
"max_days_in_cache": 7,
"days_lookup": 7,
"confidence_threshold": 0.9
},

@nox1134
Copy link

nox1134 commented Jan 28, 2024

Hi @suhaibmujahid! I'd like to work on this issue.

@suhaibmujahid
Copy link
Member

I'd like to work on this issue.

@nox1134 feel free to submit a PR.

@pramud
Copy link

pramud commented Aug 17, 2024

We need to add a fix for this in here ?

https://github.com/pre-commit/pre-commit-hooks

@rishabhjain1712
Copy link

rishabhjain1712 commented Sep 2, 2024 •
edited
Loading

hello @suhaibmujahid i'd like to work on this issue, can you assign it to me

@marco-c
Copy link
Contributor

marco-c commented Sep 16, 2024

@rishabhjain1712 no need to be assigned, feel free to work on it and submit a PR!

@hrishi-1337 hrishi-1337 linked a pull request Oct 11, 2024 that will close this issue
Open
4 tasks
@hrishi-1337
Copy link

@suhaibmujahid and @marco-c, I would appreciate it if you could take a look at my PR and provide your feedback. Excited to make my first open-source contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good-first-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added custom pre-commit hook hrishi-1337/bugbot
7 participants
@pramud @marco-c @suhaibmujahid @hrishi-1337 @PromiseFru @rishabhjain1712 @nox1134