Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scoped inline assembly ATT/Intel #295

Closed
mratsim opened this issue Nov 18, 2023 · 1 comment · Fixed by #309
Closed

Scoped inline assembly ATT/Intel #295

mratsim opened this issue Nov 18, 2023 · 1 comment · Fixed by #309
Labels
ergonomics 💯 refactoring 🚂

Comments

@mratsim
Copy link
Owner

mratsim commented Nov 18, 2023

Due to incompatibilities with other libraries using AT&T inline assembly like secp256k1 or EVMone or differential fuzzing, it would be best to scope the inline assembly otherwise only GCC can build the combination of Constantine + another lib.

See codex-storage/nim-codex#625 (comment)

cc @markspanbroek @dryajov.

This might be possible with localpassC pragma with care for assembly that is inlined at another level.
Unsure of what happens with LTO though.
@mratsim mratsim mentioned this issue Dec 2, 2023
Merged
@mratsim mratsim linked a pull request Dec 2, 2023 that will close this issue
Rework LTO, Intel Assembly syntax and default compile-options #309
Merged
@mratsim
Copy link
Owner Author

mratsim commented Dec 2, 2023

Tried in #309 it doesn't work. Intel syntax and LTO will be disabled by default except for dynamic libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ergonomics 💯 refactoring 🚂
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rework LTO, Intel Assembly syntax and default compile-options mratsim/constantine
1 participant
@mratsim