Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are covariance matrix and log file entries written by every thread? #40

Open
kdolum opened this issue May 26, 2023 · 0 comments
Open

Are covariance matrix and log file entries written by every thread? #40

kdolum opened this issue May 26, 2023 · 0 comments
Labels

Comments

@kdolum
Copy link
Collaborator

kdolum commented May 26, 2023

At the end of updateChains is some code which writes to the chain file but only in thread 0 (unless you set writeHotChains). Then it writes cov.npy and outputs a log message, without checking that we are in thread 0. Does this mean that file and message will be written simultaneously by every thread? The seems like a bug.
I'm changing this code anyway in my fixes for #10, so I could change this also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants