Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dict entries for some be/rx combos in plot_utils #7

Open
tcromartie opened this issue Nov 29, 2022 · 2 comments
Open

Missing dict entries for some be/rx combos in plot_utils #7

tcromartie opened this issue Nov 29, 2022 · 2 comments
Assignees
Labels
bug Something isn't working discussed Discussed during a NANOGrav GitFlowers Meeting.

Comments

@tcromartie
Copy link
Collaborator

We just need to add entries for all backend/receiver combos for markers and colors in plot_utils.py... easy fix but requires attention to make it look good and readable. Awful temporary fix starting at line 361 and 2093:

        # Get plot preferences
        if 'fmt' in kwargs.keys():
            mkr = kwargs['fmt']
        else:
            try:
                mkr = markers[r_b_label]
                if restype == 'both':
                    mkr_pre = '.'
            except:
                mkr = 'x'
                log.log(1, "Rec/Bknd combo doesn't have a marker label!!")
        if 'color' in kwargs.keys():
            clr = kwargs['color']
        else:
            try:
                clr = colorscheme[r_b_label]
            except:
                clr = 'k'
                log.log(1, "Rec/Bknd combo doesn't have a color!!")
@tcromartie tcromartie added the bug Something isn't working label Nov 29, 2022
@gooddc
Copy link
Collaborator

gooddc commented Nov 29, 2022

I knew about this -- I keep finding new fe/be pairs, but fortunately we have more finalized data now so we should be able to finish the list.

After that, we may want to think about making the markers/colors meaningful -- there's so many that it's tricky.

@JPGlaser JPGlaser assigned JPGlaser and tcromartie and unassigned JPGlaser May 30, 2024
@rossjjennings
Copy link
Member

The IPTA side of this was largely addressed by #54, which introduced the IPTA color scheme. But the VEGAS color schemes are a separate issue (#33).

@rossjjennings rossjjennings added the discussed Discussed during a NANOGrav GitFlowers Meeting. label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working discussed Discussed during a NANOGrav GitFlowers Meeting.
Projects
None yet
Development

No branches or pull requests

4 participants