Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If GainNode "gain" is 1, pass buffers through without modification #3

Open
kirbysayshi opened this issue Mar 25, 2019 · 0 comments
Open

If GainNode "gain" is 1, pass buffers through without modification #3

kirbysayshi opened this issue Mar 25, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@kirbysayshi
Copy link
Contributor

A GainNode could be optimized where if the gain value is exactly 1 it just passes audio through to save CPU, rather than iterating over the entire buffer needlessly.

Probably best to check if the starting, middle, and ending gain values are 1. Otherwise a rapid change could be missed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kirbysayshi