-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: JSON schema for audit-resolve.json #76
Open
Comments
I'd happily accept a PR configuring that.
Hit me up with any questions you need answered to do it.
…On Wed, Dec 6, 2023, 10:23 jase ***@***.***> wrote:
Would be great to have a JSON schema of the audit-resolve.json that is
applied initially.
like
{
"$schema": "node_modules/npm-audit-resolver/schema.json",
// ...
}
This would make clearer for devs which optional fields might be filled in
(if there are any?) and third party tools could read the format easier.
—
Reply to this email directly, view it on GitHub
<#76>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD4LP44H6OGG2HJ2UIM3QLYIA2RFAVCNFSM6AAAAABAJBR3UOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZDQMJQGU3TCOA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Hey, thanks. I realized that there are already two JSON schemas within First thought:
So the changes should probably only happen in |
Sounds about right. Just make sure it's not a breaking change and I'll take
it. :)
Planning to do a release before year ends.
…On Thu, Dec 7, 2023, 08:31 jase ***@***.***> wrote:
Hey, thanks.
I realized that there are already two JSON schemas within
audit-resolve-core. Currently these are baked into a js files (e.g.
auditFile/versions/v1.js).
First thought:
- move content of js files to schema.json files (for example
v0.schema.json)
- consume them within js files (require or readFileSync - also
depending which node version should be supported)
So the changes should probably only happen in audit-resolve-core, right?
There is also the file writing happening, where the $schema needs to be
applied as well
—
Reply to this email directly, view it on GitHub
<#76 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD4LP6MGRFPGXXTSLKOBNLYIFWFPAVCNFSM6AAAAABAJBR3UOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBUHAYTGMRUGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Ok great made a first PR containing a schema file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Would be great to have a JSON schema of the
audit-resolve.json
that is applied initially.like
This would make clearer for devs which optional fields might be filled in (if there are any?) and third party tools could read the format easier.
The text was updated successfully, but these errors were encountered: