Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for automatically removing no-longer-needed ignores? #59

Open
RichardBradley opened this issue May 24, 2022 · 2 comments
Open

Comments

@RichardBradley
Copy link

If I add an ignore to the log file, but later upgrade my app; that line will exist in the log file forever.

It might be nice to automatically prune ignores which are no longer needed? I can think of some obscure scenarios where that might conceivably be more secure, and it certainly would be tidier and make the log file easier to review.

Thanks for a great tool!

@naugtur
Copy link
Owner

naugtur commented Jun 13, 2022

That's a great feature and I thought about it first a few months into using this tool myself. Didn't come up with a satisfying process for that that'd take into account optional modules and some other corner cases I don't recall.

You probably have a simpler approach. What would you like to do to do the cleanup? Would it be just running the audit as is and dropping all rules that do not overlap with the current audit output?

@bmerigan
Copy link

I think like you said, upon a run any rules that no longer apply could be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants