Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Refactor of Nebula-Node #26

Open
wey-gu opened this issue Oct 23, 2023 · 0 comments
Open

RFC: Refactor of Nebula-Node #26

wey-gu opened this issue Oct 23, 2023 · 0 comments

Comments

@wey-gu
Copy link
Member

wey-gu commented Oct 23, 2023

@huaxiabuluo is working on a refactor of this project.

  • remove 3pp package from the repo(leave them in package*.json only)
  • introduce package-lock.json
  • jest for test
  • removed the thrift-gen code
  • more(@huaxiabuluo to add more)

master...huaxiabuluo:nebula-node:master
PR: #27

@wujjpp what do you think? He assumed no modification of dep packages and thrift-gen code was not modified manually, for now the test cases passed but not sure if it could work in production, could you help advise on this proposal?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant