Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the calibration process #1

Open
2 tasks
neilramaswamy opened this issue Mar 26, 2024 · 1 comment
Open
2 tasks

Improving the calibration process #1

neilramaswamy opened this issue Mar 26, 2024 · 1 comment

Comments

@neilramaswamy
Copy link
Owner

Currently, the calibration user-experience isn't the best:

  1. The prompts are somewhat confusing if you haven't seen them before. The input prompts are fairly vague.
  2. We ask questions that aren't exactly needed. For example, the mapper asks what direction the light are going in. They are always going to be horizontal because of how the hardware was made.
  3. We ask for the corner, but the corner is ALWAYS the top left or the bottom right.

We should do two things as part of this issue:

  • We should clarify/simplify these questions in the interactive calibration process, whenever possible.
  • We should split out the tests in the mapper file into actual unit tests, and run them as part of CI (I think GitHub Actions should work, but I'm happy to sponsor this project if needed).
@neilramaswamy
Copy link
Owner Author

@Hammad-Izhar perhaps you might be interested in this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant