Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude jackson stuff #4320

Closed
vga91 opened this issue Dec 20, 2024 · 2 comments
Closed

Exclude jackson stuff #4320

vga91 opened this issue Dec 20, 2024 · 2 comments

Comments

@vga91
Copy link
Collaborator

vga91 commented Dec 20, 2024

Exclude jackson stuff and optionally replicate the error with testContainer or so.

To replicate it, enable and run the new query API and got this error:

2024-12-19 23:09:41.844+0000 WARN  /db/recommendations/query/v2
javax.servlet.ServletException: org.glassfish.jersey.server.ContainerException: java.lang.NoSuchFieldError: READ_UNKNOWN_ENUM_VALUES_USING_DEFAULT_VALUE
        at org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:410) ~[jersey-container-servlet-core-2.43.jar:?]
        at org.glassfish.jersey.servlet.WebComponent.service(WebComponent.java:346) ~[jersey-container-servlet-core-2.43.jar:?]
        at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:359) ~[jersey-container-servlet-core-2.43.jar:?]
        at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:312) ~[jersey-container-servlet-core-2.43.jar:?]
        at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:205) ~[jersey-container-servlet-core-2.43.jar:?]
        at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:764) ~[jetty-servlet-10.0.24.jar:10.0.24]

executing this one:

curl -X POST -u <user:pwd> "<url>/db/recommendations/query/v2" \
     -H "Content-Type: application/json" \
     -H "Accept: application/json" \
     -d '{"statement":"RETURN 1 as test","parameters":{}}'
@vga91
Copy link
Collaborator Author

vga91 commented Dec 20, 2024

It seems right now that the culprit is neosemantics,
but it would be good to review the neo4j libraries that it brings along and make sure we have all of them on "provided" or exclude them from our deps.

@vga91
Copy link
Collaborator Author

vga91 commented Jan 10, 2025

Most of them are included via testImplementation and apt.

There are also many included via compileOnly,
which are equally ignored but can be added via extra-dependencies.

These however exclude jackson, e.g. here via commonExclusions.

The only two included as “implementations” (and thus integrated into the built jar) are:

  • implementation group: 'com.fasterxml.jackson.dataformat', name: 'jackson-dataformat-csv', version: '2.15.0',
    which is in APOC Core, so not editable
  • implementation group: 'com.fasterxml.jackson.dataformat', name: 'jackson-dataformat-yaml', version: '2.17.0', withoutJacksons
    which excludes via withoutJacksons as well Anyway, in case of issues, we can revert this commit and change it as an extra-dependency.

But atm they do not seem to give conflict problems.

@vga91 vga91 closed this as completed Jan 10, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done (check if cherry-pick) in APOC Extended Larus Jan 10, 2025
@vga91 vga91 moved this from Done (check if cherry-pick) to Done in APOC Extended Larus Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant