Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong typing for AsyncRelationshipDefinition __init__ param #854

Open
AnikinNN opened this issue Jan 16, 2025 · 1 comment · May be fixed by #855
Open

Wrong typing for AsyncRelationshipDefinition __init__ param #854

AnikinNN opened this issue Jan 16, 2025 · 1 comment · May be fixed by #855
Assignees
@mariusconjeaud
Labels
code_quality

Comments

@AnikinNN
Copy link

There is a typing mistake in AsyncRelationshipDefinition and all it's subclasses. The model: Optional[AsyncStructuredRel] = None parameter of __init__ method should be model: Optional[type[AsyncStructuredRel]] = None

Probably there is the same issue in sync part of lib
@mariusconjeaud
Copy link
Collaborator

Resolved in rc/5.4.3

@mariusconjeaud mariusconjeaud self-assigned this Jan 21, 2025
mariusconjeaud added a commit that referenced this issue Jan 21, 2025
@mariusconjeaud
Wrong typing for AsyncRelationshipDefinition __init__ param #854
f9c7862
@mariusconjeaud mariusconjeaud linked a pull request Jan 21, 2025 that will close this issue
Rc/5.4.3 #855
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mariusconjeaud mariusconjeaud

Labels
code_quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rc/5.4.3 neo4j-contrib/neomodel
2 participants
@mariusconjeaud @AnikinNN