Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[update_channel] send_payment failed when enabled is false #499

Open
gpBlockchain opened this issue Jan 22, 2025 · 1 comment · May be fixed by #502
Open

[update_channel] send_payment failed when enabled is false #499

gpBlockchain opened this issue Jan 22, 2025 · 1 comment · May be fixed by #502

Comments

@gpBlockchain
Copy link
Contributor

gpBlockchain commented Jan 22, 2025 •
edited
Loading

commit: 2f12f40

channel : A-B-C
0. A->C send payment success

  1. B.update_channel(id:B-C,enable:False)
  2. A->C send payment failed
  3. B->C send payment failed
  4. B->A send payment success, C->B send payment success
  5. C->A send payment return failed
    expected C->A send payment success

rpc

curl --location 'http://127.0.0.1:8251' --header 'Content-Type: application/json' --data '{
    "id": 42,
    "jsonrpc": "2.0",
    "method": "get_payment",
    "params": [
        {
            "payment_hash": "0x3257a89c3044ab8c0fc69170dedc4e1cf23f069297c3ddd44463dffb4f0b423b"
        }
    ]
}'
2025-01-22 12:13:38 [connectionpool.py:243][DEBUG] Starting new HTTP connection (1): 127.0.0.1:8251
2025-01-22 12:13:38 [connectionpool.py:546][DEBUG] http://127.0.0.1:8251 "POST / HTTP/11" 200 865
2025-01-22 12:13:38 [fiber_rpc.py:212][DEBUG] response:
{"jsonrpc": "2.0", "result": {"payment_hash": "0x3257a89c3044ab8c0fc69170dedc4e1cf23f069297c3ddd44463dffb4f0b423b", "status": "Failed", "created_at": "0x1948c35d0b5", "last_updated_at": "0x1948c35d3b0", "failed_error": "Failed to build route, PathFind error: no path found", "fee": "0x1", "router": {"nodes": [{"pubkey": "028a14277bb98a3f838df8731bd5fc5555d978ca250ed52e4c23bebd7792798e83", "amount": 2, "channel_outpoint": "0xf8c2088e39d7a47925a7b182ad01100abb7cdeac7d29f61c4db5396fcc52926d00000000"}, {"pubkey": "0296e12fc51a4cfc1b282094661826ea083d44660af6cea39f79e644a70b379ec6", "amount": 1, "channel_outpoint": "0x2e7fad7b5485dc927da31b33c4aef42ceb7bafa956e591e67997c2da94b1cd2500000000"}, {"pubkey": "03dc820db5d7cf8cee2581da3de25201dd0e0b28451c850345e0bc0f7f3e93c9a1", "amount": 1, "channel_outpoint": "0x000000000000000000000000000000000000000000000000000000000000000000000000"}]}}, "id": 42}

node3



  2025-01-22T04:12:04.662077Z  INFO fnn::fiber::graph: build_route source: Pubkey(PublicKey(838e799277bdbe234c2ed50e25ca78d95555fcd51b73f88d833f8ab97b27148aa2e9be4728bd3a559625a3e197a254ea9fa2fb44398e6ae886d1c70a0f7c5c04)) target: Pubkey(PublicKey(a1c9933e7f0fbce04503851c45280b0edd0152e23dda8125ee8ccfd7b50d82dc7bc88c29951d117677049e4dd1d66a22aab3986d55818d58d0950f5ae80916de)) amount: 1, payment_hash: Hash256(0x3257a89c3044ab8c0fc69170dedc4e1cf23f069297c3ddd44463dffb4f0b423b)
    at src/fiber/graph.rs:857
    in ractor::actor::Actor with id: "0.2", name: "Network QmRzTmctz2KnyLzsiMnFQefgMq57ScGaFKfyguMEDkcw6T"

  2025-01-22T04:12:04.662430Z DEBUG fnn::fiber::graph: probability: 0.9999997705317831 for channel_outpoint: OutPoint(0x2e7fad7b5485dc927da31b33c4aef42ceb7bafa956e591e67997c2da94b1cd2500000000) from: Pubkey(PublicKey(c69e370ba744e6799fa3cef60a66443d08ea2618669420281bfc4c1ac52fe196c28b61914bdf92804b3108fa7b518ea4f269fe4b1292fb25b0ed2ab5eb1c1c68)) => to: Pubkey(PublicKey(a1c9933e7f0fbce04503851c45280b0edd0152e23dda8125ee8ccfd7b50d82dc7bc88c29951d117677049e4dd1d66a22aab3986d55818d58d0950f5ae80916de))
    at src/fiber/graph.rs:1101
    in ractor::actor::Actor with id: "0.2", name: "Network QmRzTmctz2KnyLzsiMnFQefgMq57ScGaFKfyguMEDkcw6T"

  2025-01-22T04:12:04.662483Z DEBUG fnn::fiber::graph: probability: 0.9999997694048445 for channel_outpoint: OutPoint(0xf8c2088e39d7a47925a7b182ad01100abb7cdeac7d29f61c4db5396fcc52926d00000000) from: Pubkey(PublicKey(838e799277bdbe234c2ed50e25ca78d95555fcd51b73f88d833f8ab97b27148aa2e9be4728bd3a559625a3e197a254ea9fa2fb44398e6ae886d1c70a0f7c5c04)) => to: Pubkey(PublicKey(c69e370ba744e6799fa3cef60a66443d08ea2618669420281bfc4c1ac52fe196c28b61914bdf92804b3108fa7b518ea4f269fe4b1292fb25b0ed2ab5eb1c1c68))
    at src/fiber/graph.rs:1101
    in ractor::actor::Actor with id: "0.2", name: "Network QmRzTmctz2KnyLzsiMnFQefgMq57ScGaFKfyguMEDkcw6T"

  2025-01-22T04:12:04.662514Z DEBUG fnn::fiber::graph: probability: 0.9999997705317831 for channel_outpoint: OutPoint(0x2e7fad7b5485dc927da31b33c4aef42ceb7bafa956e591e67997c2da94b1cd2500000000) from: Pubkey(PublicKey(a1c9933e7f0fbce04503851c45280b0edd0152e23dda8125ee8ccfd7b50d82dc7bc88c29951d117677049e4dd1d66a22aab3986d55818d58d0950f5ae80916de)) => to: Pubkey(PublicKey(c69e370ba744e6799fa3cef60a66443d08ea2618669420281bfc4c1ac52fe196c28b61914bdf92804b3108fa7b518ea4f269fe4b1292fb25b0ed2ab5eb1c1c68))
    at src/fiber/graph.rs:1101
    in ractor::actor::Actor with id: "0.2", name: "Network QmRzTmctz2KnyLzsiMnFQefgMq57ScGaFKfyguMEDkcw6T"

  2025-01-22T04:12:04.662545Z DEBUG fnn::fiber::graph: probability: 0.999999311595449 for channel_outpoint: OutPoint(0x2e7fad7b5485dc927da31b33c4aef42ceb7bafa956e591e67997c2da94b1cd2500000000) from: Pubkey(PublicKey(c69e370ba744e6799fa3cef60a66443d08ea2618669420281bfc4c1ac52fe196c28b61914bdf92804b3108fa7b518ea4f269fe4b1292fb25b0ed2ab5eb1c1c68)) => to: Pubkey(PublicKey(a1c9933e7f0fbce04503851c45280b0edd0152e23dda8125ee8ccfd7b50d82dc7bc88c29951d117677049e4dd1d66a22aab3986d55818d58d0950f5ae80916de))
    at src/fiber/graph.rs:1101
    in ractor::actor::Actor with id: "0.2", name: "Network QmRzTmctz2KnyLzsiMnFQefgMq57ScGaFKfyguMEDkcw6T"

  2025-01-22T04:12:04.662575Z  INFO fnn::fiber::graph: get_route: nodes visited: 4, edges expanded: 4, time: 172.208µs 
result: [PathEdge { target: Pubkey(PublicKey(c69e370ba744e6799fa3cef60a66443d08ea2618669420281bfc4c1ac52fe196c28b61914bdf92804b3108fa7b518ea4f269fe4b1292fb25b0ed2ab5eb1c1c68)), channel_outpoint: OutPoint(0xf8c2088e39d7a47925a7b182ad01100abb7cdeac7d29f61c4db5396fcc52926d00000000), amount_received: 2, incoming_tlc_expiry: 172800000 }, PathEdge { target: Pubkey(PublicKey(a1c9933e7f0fbce04503851c45280b0edd0152e23dda8125ee8ccfd7b50d82dc7bc88c29951d117677049e4dd1d66a22aab3986d55818d58d0950f5ae80916de)), channel_outpoint: OutPoint(0x2e7fad7b5485dc927da31b33c4aef42ceb7bafa956e591e67997c2da94b1cd2500000000), amount_received: 1, incoming_tlc_expiry: 86400000 }]
    at src/fiber/graph.rs:1165
    in ractor::actor::Actor with id: "0.2", name: "Network QmRzTmctz2KnyLzsiMnFQefgMq57ScGaFKfyguMEDkcw6T"

  2025-01-22T04:12:04.669515Z DEBUG fnn::fiber::channel: Local commitment number: 13, remote commitment number: 13
    at src/fiber/channel.rs:4814
    in ractor::actor::Actor with id: "0.2", name: "Network QmRzTmctz2KnyLzsiMnFQefgMq57ScGaFKfyguMEDkcw6T"

  2025-01-22T04:12:04.745949Z DEBUG fnn::fiber::channel: Local commitment number: 13, remote commitment number: 13
    at src/fiber/channel.rs:4814
    in ractor::actor::Actor with id: "0.2", name: "Network QmRzTmctz2KnyLzsiMnFQefgMq57ScGaFKfyguMEDkcw6T"

  2025-01-22T04:12:04.776171Z DEBUG fnn::fiber::channel: handled commitment_signed peer message: CommitmentSigned { channel_id: Hash256(0xc27713a492e03e75e84a43ff5dcc65c2d747901c2dc856ff40b2cb1e64063649), funding_tx_partial_signature: Valid(Scalar(#f1a72119f561e4a3)), commitment_tx_partial_signature: Valid(Scalar(#a528000eb79a053b)), next_local_nonce: PubNonce { R1: Point(0279c3e7c9b7fc7b11b318259da4c050fe1dc90faa619e036da258b35f0a879750), R2: Point(03cb7d10d1152e0b13e2dfd1b82c1b783fd0a49a365aebad5bfa318cf7d07dc426) } }
    at src/fiber/channel.rs:696
    in ractor::actor::Actor with id: "0.2", name: "Network QmRzTmctz2KnyLzsiMnFQefgMq57ScGaFKfyguMEDkcw6T"

  2025-01-22T04:12:04.838329Z DEBUG fnn::fiber::channel: handled commitment_signed peer message: CommitmentSigned { channel_id: Hash256(0xc27713a492e03e75e84a43ff5dcc65c2d747901c2dc856ff40b2cb1e64063649), funding_tx_partial_signature: Valid(Scalar(#251fc122f8453052)), commitment_tx_partial_signature: Valid(Scalar(#3839ba193eb456d6)), next_local_nonce: PubNonce { R1: Point(0394b48fa84544b0c1d0573975fd53267f4f13896797476c999eb90abf994152de), R2: Point(03e4b69a412ebd5cb26fa347c927d438f91df265e439269e7b37c4a8cdbdedf2a5) } }
    at src/fiber/channel.rs:696
    in ractor::actor::Actor with id: "0.2", name: "Network QmRzTmctz2KnyLzsiMnFQefgMq57ScGaFKfyguMEDkcw6T"

  2025-01-22T04:12:04.914942Z DEBUG fnn::fiber::channel: Removed tlc payment_hash Hash256(0x3257a89c3044ab8c0fc69170dedc4e1cf23f069297c3ddd44463dffb4f0b423b) with reason RemoveTlcFail
    at src/fiber/channel.rs:4633
    in ractor::actor::Actor with id: "0.2", name: "Network QmRzTmctz2KnyLzsiMnFQefgMq57ScGaFKfyguMEDkcw6T"

  2025-01-22T04:12:04.918147Z DEBUG fnn::fiber::graph: Updating network graph with 1 messages
    at src/fiber/graph.rs:384
    in ractor::actor::Actor with id: "0.2", name: "Network QmRzTmctz2KnyLzsiMnFQefgMq57ScGaFKfyguMEDkcw6T"

  2025-01-22T04:12:05.423215Z  INFO fnn::fiber::graph: build_route source: Pubkey(PublicKey(838e799277bdbe234c2ed50e25ca78d95555fcd51b73f88d833f8ab97b27148aa2e9be4728bd3a559625a3e197a254ea9fa2fb44398e6ae886d1c70a0f7c5c04)) target: Pubkey(PublicKey(a1c9933e7f0fbce04503851c45280b0edd0152e23dda8125ee8ccfd7b50d82dc7bc88c29951d117677049e4dd1d66a22aab3986d55818d58d0950f5ae80916de)) amount: 1, payment_hash: Hash256(0x3257a89c3044ab8c0fc69170dedc4e1cf23f069297c3ddd44463dffb4f0b423b)
    at src/fiber/graph.rs:857
    in ractor::actor::Actor with id: "0.2", name: "Network QmRzTmctz2KnyLzsiMnFQefgMq57ScGaFKfyguMEDkcw6T"

  2025-01-22T04:12:05.423614Z DEBUG fnn::fiber::graph: probability: 0 for channel_outpoint: OutPoint(0x2e7fad7b5485dc927da31b33c4aef42ceb7bafa956e591e67997c2da94b1cd2500000000) from: Pubkey(PublicKey(c69e370ba744e6799fa3cef60a66443d08ea2618669420281bfc4c1ac52fe196c28b61914bdf92804b3108fa7b518ea4f269fe4b1292fb25b0ed2ab5eb1c1c68)) => to: Pubkey(PublicKey(a1c9933e7f0fbce04503851c45280b0edd0152e23dda8125ee8ccfd7b50d82dc7bc88c29951d117677049e4dd1d66a22aab3986d55818d58d0950f5ae80916de))
    at src/fiber/graph.rs:1101
    in ractor::actor::Actor with id: "0.2", name: "Network QmRzTmctz2KnyLzsiMnFQefgMq57ScGaFKfyguMEDkcw6T"

  2025-01-22T04:12:05.423891Z DEBUG fnn::fiber::graph: probability is too low: 0.0
    at src/fiber/graph.rs:1109
    in ractor::actor::Actor with id: "0.2", name: "Network QmRzTmctz2KnyLzsiMnFQefgMq57ScGaFKfyguMEDkcw6T"

node2



  2025-01-22T04:12:04.685303Z DEBUG fnn::fiber::channel: Local commitment number: 13, remote commitment number: 13
    at src/fiber/channel.rs:4814
    in ractor::actor::Actor with id: "0.2", name: "Network QmQV1UCzH8xZMA5ySsEjNM26Uq4J7Y1F2bnKAjUAF3uYPx"

  2025-01-22T04:12:04.714507Z DEBUG fnn::fiber::channel: handled commitment_signed peer message: CommitmentSigned { channel_id: Hash256(0xc27713a492e03e75e84a43ff5dcc65c2d747901c2dc856ff40b2cb1e64063649), funding_tx_partial_signature: Valid(Scalar(#c9c8bec314de9c78)), commitment_tx_partial_signature: Valid(Scalar(#effbb535260787c7)), next_local_nonce: PubNonce { R1: Point(0358f1c3bc3a3b34b1feedc53ef5eee7efe63be388fa54fc75d3b562127ac227e8), R2: Point(0201a53867fdbbde971f2f0616d2b87e21e09010daf2263c90025b4d9f6a072efe) } }
    at src/fiber/channel.rs:696
    in ractor::actor::Actor with id: "0.2", name: "Network QmQV1UCzH8xZMA5ySsEjNM26Uq4J7Y1F2bnKAjUAF3uYPx"

  2025-01-22T04:12:04.716072Z DEBUG fnn::fiber::channel: Local commitment number: 13, remote commitment number: 13
    at src/fiber/channel.rs:4814
    in ractor::actor::Actor with id: "0.2", name: "Network QmQV1UCzH8xZMA5ySsEjNM26Uq4J7Y1F2bnKAjUAF3uYPx"



  2025-01-22T04:12:04.902126Z DEBUG fnn::fiber::channel: handled commitment_signed peer message: CommitmentSigned { channel_id: Hash256(0xc27713a492e03e75e84a43ff5dcc65c2d747901c2dc856ff40b2cb1e64063649), funding_tx_partial_signature: Valid(Scalar(#500116c425a1c6df)), commitment_tx_partial_signature: Valid(Scalar(#d85966278dde6d73)), next_local_nonce: PubNonce { R1: Point(02026e05e96ebb2437c8955cd7c81e0e4f2fab751076be4addbf60ff088b19c5b4), R2: Point(0203821a0694827bcc673d8b136522f40492a5a0405571f37b096847b8df8a61d2) } }
    at src/fiber/channel.rs:696
    in ractor::actor::Actor with id: "0.2", name: "Network QmQV1UCzH8xZMA5ySsEjNM26Uq4J7Y1F2bnKAjUAF3uYPx"

  2025-01-22T04:12:04.902263Z DEBUG fnn::fiber::channel: Removed tlc payment_hash Hash256(0x3257a89c3044ab8c0fc69170dedc4e1cf23f069297c3ddd44463dffb4f0b423b) with reason RemoveTlcFail
    at src/fiber/channel.rs:4633
    in ractor::actor::Actor with id: "0.2", name: "Network QmQV1UCzH8xZMA5ySsEjNM26Uq4J7Y1F2bnKAjUAF3uYPx"
@contrun
Copy link
Collaborator

contrun commented Jan 22, 2025

The problem here can be reproduced with the unit test test_forward_payment_channel_disabled added in contrun@5a3f721 https://github.com/contrun/fiber/actions/runs/12902876803/job/35977185429#step:6:1406

@chenyukang chenyukang assigned chenyukang and unassigned chenyukang Jan 23, 2025
@chenyukang chenyukang linked a pull request Jan 26, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix disable channel and private channel send payment issue nervosnetwork/fiber
3 participants
@chenyukang @gpBlockchain @contrun