Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apache recipe is targeted to the :web role, why? #7

Open
donovanbray opened this issue Jan 21, 2012 · 2 comments
Open

apache recipe is targeted to the :web role, why? #7

donovanbray opened this issue Jan 21, 2012 · 2 comments

Comments

@donovanbray
Copy link

it seems to me it should be targeted to the :app role, is setting it to :web a mistake or intentional?

@nesquena
Copy link
Owner

I wrote the majority of this gem about 3 years ago or so. So I don't really recall. Probably because I considered apache as the 'web' server and it was proxying to a mongrel cluster which was the 'app' role? I wouldn't be against switching it to :app, I think it was there to allow for the distinction between web request proxy and the actual application instances.

@donovanbray
Copy link
Author

I really hate making the switch by just changing the recipe; I first modified it to follow the with_role pattern and making it selectable.

My concern in if we change the recipe, and someone who is using and following the gem upgrades and does a deploy they could get a nasty surprise if they were depending on that role, or worse used that role in ignorance just to make the recipe work.

I think what I would like to do is some kind of deprecation of the apache recipe, and add a new apache recipe, named something like apache2 (which wouldn't be innacurate as the recipe actually installs apache2 not apache1.x.) in such a way that if someone does a deploy it stops them and issues a warning, to set X preference and use apache2.

donnoman pushed a commit to donnoman/cap-recipes that referenced this issue Jul 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants