Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hacktoberfest] Convert to typescript #17

Open
jsdario opened this issue Oct 11, 2018 · 4 comments
Open

[Hacktoberfest] Convert to typescript #17

jsdario opened this issue Oct 11, 2018 · 4 comments
Labels
🎃 hacktoberfest Tasks looking for contributors

Comments

@jsdario
Copy link
Member

jsdario commented Oct 11, 2018

This task should not be very difficult since it's a single file library. I think we could gain significant value from it, achieving a lot of soundness in a pure functional library, with further mantainability for years to come.

@jsdario jsdario added the 🎃 hacktoberfest Tasks looking for contributors label Oct 11, 2018
@barthap
Copy link
Contributor

barthap commented Apr 11, 2020

Maybe converting to TypeScript is not necessary, but adding type declarations would be enough.
I made a PR #27 with colorsys.d.ts - my fork works pretty well with my TypeScript projects.

@jsdario
Copy link
Member Author

jsdario commented Apr 14, 2020

Thanks for that

@jnguyenmt
Copy link

Did the version with the typescript file get published? I'm currently not seeing it in v1.0.22

@barthap
Copy link
Contributor

barthap commented Apr 30, 2020

Yeah, it is just on github master, but npm package doesn't seem to be updated.

Temporarily, you can install it directly from github: yarn add https://github.com/netbeast/colorsys.git or npm i --save https://github.com/netbeast/colorsys.git

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎃 hacktoberfest Tasks looking for contributors
Projects
None yet
Development

No branches or pull requests

3 participants