Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkpoint loading outside of experiment is inconvinent now. We need load_checkpoint to fetch all the dependencies from the config. #86

Open
arseniybelkov opened this issue Apr 1, 2024 · 1 comment
Labels
configs Experiments and their configurations feature New feature or request good first issue Good for newcomers invalid This doesn't seem right

Comments

@arseniybelkov
Copy link
Member

arseniybelkov commented Apr 1, 2024

When using (in e.g. Jupyter Notebook)

from thunder import ThunderModule

ckpt_path = "path/to/some.ckpt"
ThunderModule.load_from_checkpoint(ckpt_path=ckpt_path, **kwargs)

there is a need to extract all the kwargs from the built config. Probably we need load_module_from_checkpoint function to fetch all the dependencies automatically.

@arseniybelkov arseniybelkov added feature New feature or request invalid This doesn't seem right configs Experiments and their configurations good first issue Good for newcomers labels Apr 1, 2024
@arseniybelkov
Copy link
Member Author

It should also not invoke logger and so on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configs Experiments and their configurations feature New feature or request good first issue Good for newcomers invalid This doesn't seem right
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant