Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Add component test for tool-navbar #491

Closed
1 of 2 tasks
jarmoza opened this issue Jul 13, 2023 · 2 comments · Fixed by #650
Closed
1 of 2 tasks

[ENH] Add component test for tool-navbar #491

jarmoza opened this issue Jul 13, 2023 · 2 comments · Fixed by #650
Assignees
@surchs
Labels
_flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again

Comments

@jarmoza
Copy link
Contributor

jarmoza commented Jul 13, 2023 •
edited by surchs
Loading

Is there an existing issue for this?

  • I have searched the existing issues

New feature

No response

Unclear documentation

We currently don't have any tests for the tool-navbar component. Look to the query tool's tests for its navbar for comparison.

Possible tests:

  • click button fires appropriate action / mutation in store
@github-actions
Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days.
We have applied the stale-issue label to indicate that this issue should be reviewed again and then either prioritized or closed.

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Aug 13, 2023
@surchs
Copy link
Contributor

surchs commented Nov 7, 2023

@rmanaem was this unlocked with #598? I think we could probably add one, now that the routing has been decoupled. wdyt?

@surchs surchs added flag:schedule Flag issue that should go on the roadmap or backlog. type:maintenance labels Nov 23, 2023
@rmanaem rmanaem moved this to Backlog in Neurobagel Nov 24, 2023
@rmanaem rmanaem removed the flag:schedule Flag issue that should go on the roadmap or backlog. label Nov 24, 2023
@surchs surchs moved this from Backlog to Specify - Active in Neurobagel Nov 28, 2023
@surchs surchs moved this from Specify - Active to Specify - Done in Neurobagel Nov 28, 2023
@surchs surchs moved this from Specify - Done to Implement - Active in Neurobagel Nov 29, 2023
@surchs surchs self-assigned this Nov 29, 2023
@surchs surchs mentioned this issue Nov 29, 2023
Closed
1 task
@surchs surchs moved this from Implement - Active to Implement - Done in Neurobagel Nov 29, 2023
@surchs surchs mentioned this issue Nov 29, 2023
Merged
6 tasks
@rmanaem rmanaem moved this from Implement - Done to Community in Neurobagel Nov 29, 2023
@rmanaem rmanaem moved this from Community to Review - Active in Neurobagel Nov 29, 2023
@github-project-automation github-project-automation bot moved this from Review - Active to Review - Done in Neurobagel Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@surchs surchs

Labels
_flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again
Projects
Neurobagel
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FIX] allow users to use the browser-back button neurobagel/annotation_tool
3 participants
@surchs @jarmoza @rmanaem