Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow selective /{data_element_URI} request based on specified nodes #36

Open
alyssadai opened this issue Nov 21, 2023 · 0 comments
Open

Allow selective /{data_element_URI} request based on specified nodes #36

alyssadai opened this issue Nov 21, 2023 · 0 comments
Labels
someday Not a priority right now, but we want to keep this around to think or discuss more.

Comments

@alyssadai
Copy link
Contributor

alyssadai commented Nov 21, 2023 •
edited
Loading

Currently, a request to /attributes/{data_element_URI} to get all the instances of a class will always go out to all known nodes.

Depending on who/what we envision using this endpoint (right now, only the query tool, to populate dropdown options?), we may want to restrict this by adding a query parameter for a selected subset of nodes, similar to the /query/ endpoint, e.g.:

node_urls : list[str]
        List of Neurobagel nodes to send the query to.

Originally posted by @surchs in #30 (comment)
@alyssadai alyssadai added flag:discuss Flag issue that needs to be discussed before it can be implemented. flag:schedule Flag issue that should go on the roadmap or backlog. feat:improve labels Nov 21, 2023
@alyssadai alyssadai mentioned this issue Nov 21, 2023
Merged
6 tasks
@rmanaem rmanaem removed the flag:schedule Flag issue that should go on the roadmap or backlog. label Nov 22, 2023
@alyssadai alyssadai added the flag:schedule Flag issue that should go on the roadmap or backlog. label Jan 31, 2024
@rmanaem rmanaem added someday Not a priority right now, but we want to keep this around to think or discuss more. and removed flag:discuss Flag issue that needs to be discussed before it can be implemented. flag:schedule Flag issue that should go on the roadmap or backlog. labels Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
someday Not a priority right now, but we want to keep this around to think or discuss more.
Projects
Neurobagel
Status: No status
Milestone
No milestone
Development

No branches or pull requests
3 participants
@surchs @alyssadai @rmanaem