Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor warning raising #41

Open
alyssadai opened this issue Dec 4, 2023 · 1 comment
Open

Refactor warning raising #41

alyssadai opened this issue Dec 4, 2023 · 1 comment
Labels
refactor Simplifying or restructuring existing code or documentation.

Comments

@alyssadai
Copy link
Contributor

alyssadai commented Dec 4, 2023

Warnings related to local nodes not being available could be handled by parse_nodes_as_dict().

We may also want to make the warning less generic / confusing (are there no local nodes, did the file not exist, was the file empty ...)

if not local_nodes:
warnings.warn(
f"No local Neurobagel nodes defined or found. Federation will be limited to nodes available from the Neurobagel public node directory {node_directory_url}. "
"(To specify one or more local nodes to federate over, define them in a 'local_nb_nodes.json' file in the current directory and relaunch the API.)\n"
)

This would also require updating several of the tests.

Originally posted by @surchs in #39 (review)

@alyssadai alyssadai added refactor Simplifying or restructuring existing code or documentation. type:maintenance labels Dec 4, 2023
Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 75 days.
We have applied the _flag:stale label to indicate that this issue should be reviewed again.
When you review, please reread the spec and then apply one of these three options:

  • prioritize: apply the flag:schedule label to suggest moving this issue into the backlog now
  • close: if the issue is no longer relevant, explain why (give others a chance to reply) and then close.
  • archive: sometimes an issue has important information or ideas but we won't work on it soon. In this case
    apply the someday label to show that this won't be prioritized. The stalebot will ignore issues with this
    label in the future. Use sparingly!

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Feb 18, 2024
@github-actions github-actions bot removed the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Simplifying or restructuring existing code or documentation.
Projects
None yet
Development

No branches or pull requests

2 participants