-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple version tag from the repo #111
Comments
I think there is a related problem (without the same performance impact) because we pull the neurobagel logo live every time the app loads for a user - couldn't find the issue for that, so maybe we need to make one |
I agree that it's better to have this baked in somewhere instead of pulling from the repo every time but having it hardcoded and having to update it every time a new release is made seems inefficient. |
Agree, we'd need something that runs automatically at release time, but only once |
We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 75 days.
|
Addressed in #390 |
Right now we fetch the release number every time any user interacts with the App:
query-tool/src/components/Navbar.tsx
Lines 9 to 21 in 9d110ba
This will break real quick with some level of load - and even just from running the e2e test suite a couple of times:
There is really no reason to fetch this at all! The purpose of string is to tell you what version you are running, not what version is available. So this number should get baked into the build of the tool and read at build time from the build context, not from the repository!
The text was updated successfully, but these errors were encountered: