Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make app path configurable #226

Closed
rmanaem opened this issue Jul 25, 2024 · 1 comment · Fixed by #227
Closed

Make app path configurable #226

rmanaem opened this issue Jul 25, 2024 · 1 comment · Fixed by #227
Assignees
@rmanaem
Labels
released This issue/pull request has been released.

Comments

@rmanaem
Copy link
Contributor

rmanaem commented Jul 25, 2024 •
edited
Loading

Currently, the path for the app in react-router-dom is configured to / so any custom configuration (e.g., caddy, nginx, etc) that tries to deploy the app on a path other than / results in a 404 error (like below in dev mode).
To address this we want to make this path configurable via the env var NB_QUERY_PATH.

Image
@rmanaem rmanaem converted this from a draft issue Jul 25, 2024
@rmanaem rmanaem self-assigned this Jul 25, 2024
@rmanaem rmanaem mentioned this issue Jul 26, 2024
Merged
7 tasks
@rmanaem rmanaem moved this from Implement - Active to Implement - Done in Neurobagel Jul 26, 2024
This was referenced Jul 26, 2024
Closed
Closed
@surchs surchs moved this from Implement - Done to Review - Active in Neurobagel Aug 1, 2024
@github-project-automation github-project-automation bot moved this from Review - Active to Review - Done in Neurobagel Aug 2, 2024
@neurobagel-bot Neurobagel Bot
Copy link
Contributor

neurobagel-bot bot commented Aug 2, 2024

🚀 Issue was released in v0.3.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmanaem rmanaem

Labels
released This issue/pull request has been released.
Projects
Neurobagel
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ENH] Added NB_QUERY_PATH env var to configure path variable neurobagel/query-tool
1 participant
@rmanaem