Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find more descriptive ENV and var name for app root path #236

Closed
surchs opened this issue Aug 1, 2024 · 2 comments · Fixed by #246
Closed

Find more descriptive ENV and var name for app root path #236

surchs opened this issue Aug 1, 2024 · 2 comments · Fixed by #246
Assignees
@rmanaem
Labels
quick fix Minimal planning and/or implementation work required. refactor Simplifying or restructuring existing code or documentation. released This issue/pull request has been released.

Comments

@surchs
Copy link
Contributor

surchs commented Aug 1, 2024

I think we should find a more descriptive name for NB_QUERY_URL_PATH, especially for the internal variable name queryURLPath because when I see that in the codebase I am immediately thinking of a parameter I will include in a request to the f-API.

Originally posted by @surchs in #227 (review)
@alyssadai alyssadai added the flag:schedule Flag issue that should go on the roadmap or backlog. label Aug 2, 2024
@surchs surchs moved this to Backlog in Neurobagel Aug 2, 2024
@surchs surchs removed the flag:schedule Flag issue that should go on the roadmap or backlog. label Aug 2, 2024
@rmanaem rmanaem added the quick fix Minimal planning and/or implementation work required. label Aug 5, 2024
@rmanaem rmanaem moved this from Backlog to Specify - Active in Neurobagel Aug 6, 2024
@rmanaem
Copy link
Contributor

rmanaem commented Aug 6, 2024 •
edited
Loading

How about NB_QUERY_APP_BASE_PATH for the env var and appBasePath for the var itself?

@rmanaem rmanaem added refactor Simplifying or restructuring existing code or documentation. type:maintenance labels Aug 7, 2024
@rmanaem rmanaem self-assigned this Aug 7, 2024
@rmanaem rmanaem mentioned this issue Aug 7, 2024
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from Review - Active to Review - Done in Neurobagel Aug 9, 2024
@neurobagel-bot Neurobagel Bot
Copy link
Contributor

neurobagel-bot bot commented Aug 9, 2024

🚀 Issue was released in v0.4.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmanaem rmanaem

Labels
quick fix Minimal planning and/or implementation work required. refactor Simplifying or restructuring existing code or documentation. released This issue/pull request has been released.
Projects
Neurobagel
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[REF] Renamed NB_QUERY_URL_PATH env var to NB_QUERY_APP_BASE_PATH neurobagel/query-tool
3 participants
@surchs @alyssadai @rmanaem