Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back extra download button for the URI-based query result file #387

Closed
4 tasks
alyssadai opened this issue Dec 2, 2024 · 3 comments · Fixed by #396
Closed
4 tasks

Add back extra download button for the URI-based query result file #387

alyssadai opened this issue Dec 2, 2024 · 3 comments · Fixed by #396
Assignees
Labels
released This issue/pull request has been released.

Comments

@alyssadai
Copy link
Contributor

alyssadai commented Dec 2, 2024

I would suggest renaming the buttons to something like:

Download selected query results (file with descriptive labels)

and

Download selected query results with URIs (file w/ URIs)

  • ideally, on hover, this could contain a brief description such as "For details on controlled terms in the harmonized results" or something for a less technical user

TODO

  • Have a button with cohort results label and a download icon
  • Have a button with machine cohort results label and download icon
  • Have a hover tooltip (hover on button or hover on little ? icon near button) that explains briefly what both files are. Essentially: "You probably want the cohort results file unless you do fancy stuff)
  • optional: make both buttons in one button (split button) and default to the "human" file
@alyssadai alyssadai added the flag:schedule Flag issue that should go on the roadmap or backlog. label Dec 2, 2024
@alyssadai alyssadai moved this to Backlog in Neurobagel Dec 3, 2024
@alyssadai alyssadai removed the flag:schedule Flag issue that should go on the roadmap or backlog. label Dec 3, 2024
@surchs surchs moved this from Backlog to Specify - Active in Neurobagel Dec 4, 2024
@surchs
Copy link
Contributor

surchs commented Dec 4, 2024

Let's use something like a split button and default to the human file: https://mui.com/material-ui/react-button-group/#split-button
Image

@surchs surchs moved this from Specify - Active to Specify - Done in Neurobagel Dec 4, 2024
@rmanaem
Copy link
Contributor

rmanaem commented Dec 6, 2024

Originally posted #389 (comment)

Hey @neurobagel/dev, a quick additional thought on this I realized we didn't discuss in #376 .

How do we feel about renaming the results files to something clearer, now that we no longer have dataset and participant files:

One suggestion:

cohort-participant-machine-results.tsv -> neurobagel-query-results-with-URIs.tsv
cohort-participant-results.tsv -> neurobagel-query-results.tsv

Goal would be that a user should be able to:

Easily identify which files are Neurobagel query tool results files within their own FS
Know, semi-intuitively, based off the title what the files contain (ideally, they would convey that they are the same info, just in two different representations)

@rmanaem rmanaem moved this from Specify - Done to Implement - Active in Neurobagel Dec 10, 2024
@rmanaem rmanaem self-assigned this Dec 10, 2024
@rmanaem rmanaem moved this from Implement - Active to Implement - Done in Neurobagel Dec 11, 2024
@surchs surchs moved this from Implement - Done to Review - Active in Neurobagel Dec 11, 2024
@github-project-automation github-project-automation bot moved this from Review - Active to Review - Done in Neurobagel Dec 13, 2024
Copy link
Contributor

🚀 Issue was released in v0.8.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
Status: Review - Done
Development

Successfully merging a pull request may close this issue.

3 participants