-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NB_IS_FEDERATION_API
is not parsed correctly
#84
Comments
I feel like this has come up before. Maybe in the API URL parsing? |
Not in this tool. I believe we had an issue with Vue being opinionated about the capitalization of props. |
NB_IS_FEDERATION_API
is not parsed appropriatelyNB_IS_FEDERATION_API
is not parsed correctly
No, I meant reading in ENV variables and having to deal with any string evaluating true. I can't remember where that was - but regardless, we can probably figure out a reasonable solution again. |
Sounds familiar but I don't recall that. |
🚀 Issue was released in |
The
NB_IS_FEDERATION_API
is currently being parsed as astring
which in JS/TS as long as it is not an empty string is considered a truthy value therefore even when the env var is set tofalse
it will be parsed astrue
.query-tool/src/utils/constants.ts
Lines 12 to 13 in 99fc5c0
The text was updated successfully, but these errors were encountered: