Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Informational popup when New XKit is updated in Firefox #2184

Open
marcustyphoon opened this issue Dec 29, 2024 · 0 comments
Open

Comments

@marcustyphoon
Copy link

marcustyphoon commented Dec 29, 2024

In Firefox, automatic extension updates cause the extension to be reloaded, in-place, in every currently open Tumblr tab. This can cause all sorts of bugs (such as duplicating the New XKit control button) unless the extension is very carefully designed.

This seems particularly important to handle in a Tumblr extension because many users seem to keep the same Tumblr tabs for weeks or months(?), per the large number of issues I see reported in Tumblr posts that indicate that this is being done and are fixed with a simple refresh.

We could make a popup appear when this occurs rather than silently having potentially erroneous behavior, perhaps with an optional refresh-this-page button.

We declined to do this in XKit Rewritten (AprilSylph/XKit-Rewritten#451) in favor of attempting to fix most possible erroneous behavior that results from these updates. This was pretty complicated, so it doesn't make much sense as a strategy for this codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant