Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] fix!: make 'box-sizing: border-box' a default behaviour for all containers #6390

Merged
merged 1 commit into from
Jan 17, 2025
Merged

[next] fix!: make 'box-sizing: border-box' a default behaviour for all containers #6390

merged 1 commit into from
Jan 17, 2025
+19 −27

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

🖼️ Screenshots

Apart from NcPopover, there should be no visual changes from this PR

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews vue 3 Related to the vue 3 migration labels Jan 16, 2025
@Antreesy Antreesy added this to the 9.0.0-alpha.6 milestone Jan 16, 2025
@Antreesy Antreesy self-assigned this Jan 16, 2025
@Antreesy Antreesy mentioned this pull request Jan 16, 2025
Open
susnux
susnux approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense but did not check all components

ShGKme
ShGKme reviewed Jan 16, 2025
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: deep does nothing to universal selector * in Vue 3, it is never scoped.

https://github.com/vuejs/core/blob/2e6ec398114bef171984782cb9cee36d460b047a/packages/compiler-sfc/src/style/pluginScoped.ts#L219-L220

src/components/NcAppNavigation/NcAppNavigation.vue Outdated Show resolved Hide resolved
src/components/NcContent/NcContent.vue Outdated Show resolved Hide resolved
src/components/NcModal/NcModal.vue Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@Antreesy Antreesy force-pushed the fix/next/6384/box-sizing branch from 298add1 to 00a1be5 Compare January 17, 2025 18:05
@ShGKme
Copy link
Contributor

ShGKme commented Jan 17, 2025

cc @dartcafe to know about the change

@Antreesy Antreesy merged commit 7ae3143 into next Jan 17, 2025
20 checks passed
@Antreesy Antreesy deleted the fix/next/6384/box-sizing branch January 17, 2025 20:23
@dartcafe
Copy link
Contributor

Thanks, I already watched this topic, since I believe it may solve an actual problem I have with the NcModal. At least I hope. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux susnux approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews bug Something isn't working vue 3 Related to the vue 3 migration
Projects
None yet
Milestone
9.0.0-alpha.6
Development

Successfully merging this pull request may close these issues.
4 participants
@Antreesy @ShGKme @dartcafe @susnux