Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(occ): correct app_api:app:update enabled state of ExApps, introduce helper options #478

Merged
merged 3 commits into from
Dec 27, 2024

Conversation

andrey18106
Copy link
Collaborator

@andrey18106 andrey18106 commented Dec 26, 2024

Resolves: #474

This PR corrects AppAPI occ app_api:app:update command logic in the following way:

  1. By default disabled ExApps are not updated. Use option --include-disabled to update disabled ExApps too.
  2. During update ExApp is enabled to perform initialization step, if it was disabled before update - by default it will be disabled after update.

@andrey18106 andrey18106 requested review from bigcat88 and oleksandr-nc and removed request for bigcat88 December 26, 2024 01:15
lib/Command/ExApp/Update.php Outdated Show resolved Hide resolved
lib/Command/ExApp/Update.php Outdated Show resolved Hide resolved
lib/Command/ExApp/Update.php Outdated Show resolved Hide resolved
lib/Command/ExApp/Update.php Outdated Show resolved Hide resolved
Signed-off-by: Andrey Borysenko <[email protected]>
@andrey18106 andrey18106 enabled auto-merge (squash) December 27, 2024 13:16
@andrey18106
Copy link
Collaborator Author

/backport to stable30

@andrey18106 andrey18106 merged commit 217a6f9 into main Dec 27, 2024
31 checks passed
@andrey18106 andrey18106 deleted the fix/occ/update-enabled-state branch December 27, 2024 13:25
Copy link

backportbot bot commented Dec 27, 2024

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/478/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c1fb11e5 405b0fc6 80ea4d77

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/478/stable30

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress
fatal: cherry-pick failed


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

andrey18106 added a commit that referenced this pull request Dec 27, 2024
…ps, introduce helper options (#479)

Manual backport of: #478

---------

Signed-off-by: Andrey Borysenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating an external app must not automatically enable it
3 participants