-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(occ): correct app_api:app:update
enabled state of ExApps, introduce helper options
#478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce helper options Signed-off-by: Andrey Borysenko <[email protected]>
andrey18106
requested review from
bigcat88 and
oleksandr-nc
and removed request for
bigcat88
December 26, 2024 01:15
oleksandr-nc
requested changes
Dec 26, 2024
Signed-off-by: Andrey Borysenko <[email protected]>
bigcat88
reviewed
Dec 27, 2024
oleksandr-nc
approved these changes
Dec 27, 2024
Signed-off-by: Andrey Borysenko <[email protected]>
/backport to stable30 |
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/478/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c1fb11e5 405b0fc6 80ea4d77
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/478/stable30 Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
andrey18106
added a commit
that referenced
this pull request
Dec 27, 2024
…ps, introduce helper options (#479) Manual backport of: #478 --------- Signed-off-by: Andrey Borysenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #474
This PR corrects AppAPI
occ app_api:app:update
command logic in the following way:--include-disabled
to update disabled ExApps too.