Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Download Limit Cannot Be Undone #423

Open
i2h3 opened this issue Nov 14, 2024 · 1 comment
Open

Default Download Limit Cannot Be Undone #423

i2h3 opened this issue Nov 14, 2024 · 1 comment
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working

Comments

@i2h3
Copy link

i2h3 commented Nov 14, 2024

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce

  1. Have the files_downloadlimit app installed (in my Nextcloud All-in-One instance it was already bundled on installation).
  2. Go to Administration SettingsSharing.
  3. Set a value for default download limit.

Expected behaviour

I can remove the value again any time after it was set.

Actual behaviour

Trying to enter any value other than a positive integer results in the error message:

The minimum limit is 1

So, after entering a value download limits are enforced on all newly created external shares (see #422 as an example) and it cannot be changed anymore.

Image

Server configuration

Web server: Whatever is default in most recent Nextcloud All-in-One release 🤷🏻‍♀️

Database: PostgreSQL

PHP version: Whatever is default in most recent Nextcloud All-in-One release 🤷🏻‍♀️

Nextcloud version: 30.0.1.2

List of activated apps
Enabled:
  - activity: 3.0.0
  - admin_audit: 1.20.0
  - app_api: 4.0.0
  - bruteforcesettings: 3.0.0
  - calendar: 5.0.1
  - circles: 30.0.0-dev
  - cloud_federation_api: 1.13.0
  - comments: 1.20.1
  - contacts: 6.1.0
  - contactsinteraction: 1.11.0
  - dashboard: 7.10.0
  - dav: 1.31.1
  - federatedfilesharing: 1.20.0
  - federation: 1.20.0
  - files: 2.2.0
  - files_downloadlimit: 3.0.0
  - files_pdfviewer: 3.0.0
  - files_reminders: 1.3.0
  - files_sharing: 1.22.0
  - files_trashbin: 1.20.1
  - files_versions: 1.23.0
  - firstrunwizard: 3.0.0
  - logreader: 3.0.0
  - lookup_server_connector: 1.18.0
  - nextcloud-aio: 0.6.0
  - nextcloud_announcements: 2.0.0
  - notes: 4.11.0
  - notifications: 3.0.0
  - notify_push: 0.7.0
  - oauth2: 1.18.1
  - password_policy: 2.0.0
  - photos: 3.0.2
  - privacy: 2.0.0
  - provisioning_api: 1.20.0
  - related_resources: 1.5.0
  - serverinfo: 2.0.0
  - settings: 1.13.0
  - sharebymail: 1.20.0
  - spreed: 20.0.2
  - support: 2.0.0
  - survey_client: 2.0.0
  - systemtags: 1.20.0
  - tasks: 0.16.1
  - text: 4.1.0
  - theming: 2.5.0
  - twofactor_backupcodes: 1.19.0
  - twofactor_totp: 12.0.0-dev
  - user_status: 1.10.0
  - viewer: 3.0.0
  - weather_status: 1.10.0
  - webhook_listeners: 1.1.0-dev
  - workflowengine: 2.12.0
Disabled:
  - deck: 1.14.2 (installed 1.14.2)
  - encryption: 2.18.0
  - files_external: 1.22.0
  - recommendations: 3.0.0 (installed 3.0.0)
  - suspicious_login: 8.0.0
  - twofactor_nextcloud_notification: 4.0.0
  - user_ldap: 1.21.0
Nextcloud configuration
{
    "system": {
        "upgrade.disable-web": true,
        "maintenance": false,
        "preview_max_x": 2048,
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "loglevel": 2,
        "trusted_domains": [
            "localhost",
            "***REMOVED SENSITIVE VALUE***"
        ],
        "overwrite.cli.url": "https:\/\/***REMOVED SENSITIVE VALUE***\/",
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "activity_expire_days": 30,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "maintenance_window_start": 100,
        "DOMAIN": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "pgsql",
        "jpeg_quality": 60,
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "check_data_directory_permissions": false,
        "files_external_allow_create_new_local": false,
        "one-click-instance.user-limit": 100,
        "logfile": "\/var\/www\/html\/data\/nextcloud.log",
        "memcache.local": "\\OC\\Memcache\\APCu",
        "auth.bruteforce.protection.enabled": true,
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "enable_previews": true,
        "preview_max_y": 2048,
        "installed": true,
        "apps_paths": [
            {
                "path": "\/var\/www\/html\/apps",
                "url": "\/apps",
                "writable": false
            },
            {
                "path": "\/var\/www\/html\/custom_apps",
                "url": "\/custom_apps",
                "writable": true
            }
        ],
        "share_folder": "\/Shared",
        "upgrade.cli-upgrade-link": "https:\/\/github.com\/nextcloud\/all-in-one\/discussions\/2726",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "updatedirectory": "\/nc-updater",
        "dbport": "",
        "log.condition": {
            "apps": [
                "admin_audit"
            ]
        },
        "mail_smtpmode": "smtp",
        "htaccess.RewriteBase": "\/",
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "one-click-instance": true,
        "trusted_proxies": "***REMOVED SENSITIVE VALUE***",
        "trashbin_retention_obligation": "auto, 30",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "preview_imaginary_url": "***REMOVED SENSITIVE VALUE***",
        "overwriteprotocol": "https",
        "log_rotate_size": 10485760,
        "version": "30.0.1.2",
        "dbtableprefix": "oc_",
        "dbpersistent": false,
        "enabledPreviewProviders": {
            "7": "OC\\Preview\\Krita",
            "3": "OC\\Preview\\MP3",
            "4": "OC\\Preview\\TXT",
            "0": "OC\\Preview\\Imaginary",
            "5": "OC\\Preview\\OpenDocument",
            "1": "OC\\Preview\\Image",
            "6": "OC\\Preview\\Movie",
            "2": "OC\\Preview\\MarkDown"
        },
        "app_install_overwrite": [
            "nextcloud-aio"
        ],
        "davstorage.request_timeout": 3600,
        "one-click-instance.link": "https:\/\/nextcloud.com\/all-in-one\/",
        "overwritehost": "***REMOVED SENSITIVE VALUE***",
        "redis": {
            "password": "***REMOVED SENSITIVE VALUE***",
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 6379
        },
        "ratelimit.protection.enabled": true,
        "versions_retention_obligation": "auto, 30",
        "log_type": "file",
        "allow_local_remote_servers": true,
        "preview_imaginary_key": "***REMOVED SENSITIVE VALUE***",
        "simpleSignUpLink.shown": false
    }
}

Browser

Browser name: Safari 18.1 (20619.2.8.11.10) as well as Google Chrome Version 130.0.6723.117 (Official Build) (arm64)

Operating system: macOS

@i2h3 i2h3 added 0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working labels Nov 14, 2024
@ThoemeSee
Copy link

👍 Same for Version 29.0.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants