Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update workflows + remove broken ones #1109

Merged
merged 2 commits into from
Jan 13, 2025
Merged

CI: Update workflows + remove broken ones #1109

merged 2 commits into from
Jan 13, 2025

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jan 13, 2025

  • Update all workflows from organization repository
  • fix invalid CI results because of outdated "-when-unrelated" workflows
    Those workflows were replaced with the filter ("changes") step in the
    workflows, so those workflows were blocking some CI runs where the CI
    would have been required and lead to false-positive ("green") results.

You can see #1076 for a false-green "node" ci run. This would have been prevented with this (removing the outdated scripts).

Signed-off-by: Ferdinand Thiessen <[email protected]>
…flows

Those workflows were replaced with the filter ("changes") step in the
workflows, so those workflows were blocking some CI runs where the CI
would have been required and lead to false-positive ("green") results.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
Copy link
Contributor Author

susnux commented Jan 13, 2025

/backport to stable30

@susnux
Copy link
Contributor Author

susnux commented Jan 13, 2025

/backport to stable29

@szaimen
Copy link
Collaborator

szaimen commented Jan 13, 2025

You can see #1076 for a false-green "node" ci run. This would have been prevented with this (removing the outdated scripts).

Nice!

Thanks a lot for the update of the workflows! 😊

@szaimen szaimen added this to the Nextcloud 31 milestone Jan 13, 2025
@szaimen szaimen merged commit 3e6e54b into master Jan 13, 2025
39 checks passed
Copy link

backportbot bot commented Jan 13, 2025

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/1109/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 02f9fe8d 211038e4

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1109/stable29

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@AndyScherzinger
Copy link
Member

Thanks a lot @susnux - beware that v29 backport failed and is missing (but important to have)

@susnux
Copy link
Contributor Author

susnux commented Jan 14, 2025

@AndyScherzinger the backports are here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants