Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(composer): fix running composer with --no-dev option #1112

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Jan 15, 2025

Otherwise testing with my easy-test container fails as that uses the --no-dev option for composer install.

@szaimen szaimen changed the title fix(composer): fix running composer with --no-dev option fix(composer): fix running composer with --no-dev option Jan 15, 2025
@szaimen szaimen added this to the Nextcloud 31 milestone Jan 15, 2025
@szaimen szaimen marked this pull request as ready for review January 15, 2025 11:30
@szaimen szaimen requested review from susnux and danxuliu January 15, 2025 11:31
@szaimen
Copy link
Collaborator Author

szaimen commented Jan 15, 2025

/backport to stable30

@szaimen
Copy link
Collaborator Author

szaimen commented Jan 15, 2025

/backport to stable29

Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@danxuliu danxuliu merged commit cb18bad into master Jan 15, 2025
39 checks passed
@danxuliu danxuliu deleted the enh/noid/fix-install branch January 15, 2025 16:46
@szaimen
Copy link
Collaborator Author

szaimen commented Jan 15, 2025

Okay, looks like the problem is not existing in stable30 and below. So backports are not needed.

@nextcloud nextcloud deleted a comment from backportbot bot Jan 15, 2025
@nextcloud nextcloud deleted a comment from backportbot bot Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants