From 5be9b96c9dd486d71333d0308a262b52acf9ab9e Mon Sep 17 00:00:00 2001
From: jld3103 <jld3103yt@gmail.com>
Date: Thu, 14 Dec 2023 15:23:05 +0100
Subject: [PATCH] fix(nextcloud): Avoid race conditions in tests

Signed-off-by: jld3103 <jld3103yt@gmail.com>
---
 packages/nextcloud/test/core_test.dart   |  4 ++--
 packages/nextcloud/test/notes_test.dart  |  2 +-
 packages/nextcloud/test/webdav_test.dart | 20 ++++++++++----------
 3 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/packages/nextcloud/test/core_test.dart b/packages/nextcloud/test/core_test.dart
index e0861fe56e6..ee507bcb8a4 100644
--- a/packages/nextcloud/test/core_test.dart
+++ b/packages/nextcloud/test/core_test.dart
@@ -145,7 +145,7 @@ void main() {
       group('App password', () {
         test('Delete', () async {
           await client.core.appPassword.deleteAppPassword();
-          expect(
+          await expectLater(
             () => client.core.appPassword.deleteAppPassword(),
             throwsA(predicate((final e) => (e! as DynamiteApiException).statusCode == 401)),
           );
@@ -193,7 +193,7 @@ void main() {
           expect(response.body.poll.endpoint, startsWith('http://localhost'));
           expect(response.body.poll.token, isNotEmpty);
 
-          expect(
+          await expectLater(
             () => client.core.clientFlowLoginV2.poll(token: response.body.poll.token),
             throwsA(predicate<DynamiteApiException>((final e) => e.statusCode == 404)),
           );
diff --git a/packages/nextcloud/test/notes_test.dart b/packages/nextcloud/test/notes_test.dart
index 9ffc7097292..2b788363b35 100644
--- a/packages/nextcloud/test/notes_test.dart
+++ b/packages/nextcloud/test/notes_test.dart
@@ -120,7 +120,7 @@ void main() {
           title: 'b',
           ifMatch: '"${response.body.etag}"',
         );
-        expect(
+        await expectLater(
           () => client.notes.updateNote(
             id: response.body.id,
             title: 'c',
diff --git a/packages/nextcloud/test/webdav_test.dart b/packages/nextcloud/test/webdav_test.dart
index bf865b2ce34..7052913ef0f 100644
--- a/packages/nextcloud/test/webdav_test.dart
+++ b/packages/nextcloud/test/webdav_test.dart
@@ -469,7 +469,7 @@ void main() {
           }
 
           test('put_no_parent', () async {
-            expect(
+            await expectLater(
               () => client.webdav.put(Uint8List(0), PathUri.parse('409me/noparent.txt')),
               // https://github.com/nextcloud/server/issues/39625
               throwsA(predicate<DynamiteApiException>((final e) => e.statusCode == 409)),
@@ -484,7 +484,7 @@ void main() {
           });
 
           test('delete_null', () async {
-            expect(
+            await expectLater(
               () => client.webdav.delete(PathUri.parse('test.txt')),
               throwsA(predicate<DynamiteApiException>((final e) => e.statusCode == 404)),
             );
@@ -500,7 +500,7 @@ void main() {
           test('mkcol_again', () async {
             await client.webdav.mkcol(PathUri.parse('test'));
 
-            expect(
+            await expectLater(
               () => client.webdav.mkcol(PathUri.parse('test')),
               throwsA(predicate<DynamiteApiException>((final e) => e.statusCode == 405)),
             );
@@ -514,7 +514,7 @@ void main() {
           });
 
           test('mkcol_no_parent', () async {
-            expect(
+            await expectLater(
               () => client.webdav.mkcol(PathUri.parse('409me/noparent')),
               throwsA(predicate<DynamiteApiException>((final e) => e.statusCode == 409)),
             );
@@ -535,7 +535,7 @@ void main() {
             await client.webdav.mkcol(PathUri.parse('src'));
             await client.webdav.mkcol(PathUri.parse('dst'));
 
-            expect(
+            await expectLater(
               () => client.webdav.copy(PathUri.parse('src'), PathUri.parse('dst')),
               throwsA(predicate<DynamiteApiException>((final e) => e.statusCode == 412)),
             );
@@ -547,7 +547,7 @@ void main() {
           test('copy_nodestcoll', () async {
             await client.webdav.mkcol(PathUri.parse('src'));
 
-            expect(
+            await expectLater(
               () => client.webdav.copy(PathUri.parse('src'), PathUri.parse('nonesuch/dst')),
               throwsA(predicate<DynamiteApiException>((final e) => e.statusCode == 409)),
             );
@@ -562,7 +562,7 @@ void main() {
             await client.webdav.copy(PathUri.parse('src'), PathUri.parse('dst1'));
             await client.webdav.copy(PathUri.parse('src'), PathUri.parse('dst2'));
 
-            expect(
+            await expectLater(
               () => client.webdav.copy(PathUri.parse('src'), PathUri.parse('dst1')),
               throwsA(predicate<DynamiteApiException>((final e) => e.statusCode == 412)),
             );
@@ -592,7 +592,7 @@ void main() {
             var response = await client.webdav.move(PathUri.parse('src1.txt'), PathUri.parse('dst.txt'));
             expect(response.statusCode, 201);
 
-            expect(
+            await expectLater(
               () => client.webdav.move(PathUri.parse('src2.txt'), PathUri.parse('dst.txt')),
               throwsA(predicate<DynamiteApiException>((final e) => e.statusCode == 412)),
             );
@@ -611,7 +611,7 @@ void main() {
             await client.webdav.copy(PathUri.parse('src'), PathUri.parse('dst2'));
             await client.webdav.move(PathUri.parse('src'), PathUri.parse('dst1'));
 
-            expect(
+            await expectLater(
               () => client.webdav.move(PathUri.parse('dst1'), PathUri.parse('dst2')),
               throwsA(predicate<DynamiteApiException>((final e) => e.statusCode == 412)),
             );
@@ -627,7 +627,7 @@ void main() {
             final response = await client.webdav.delete(PathUri.parse('dst1/sub'));
             expect(response.statusCode, 204);
 
-            expect(
+            await expectLater(
               () => client.webdav.move(PathUri.parse('dst2'), PathUri.parse('noncoll')),
               throwsA(predicate<DynamiteApiException>((final e) => e.statusCode == 412)),
             );