-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Iterable instead of List for array request parameters #842
Comments
We need to look out for the serializers and their registered builders when changing the types. |
Yeah, I think this doesn't actually make a lot of sense. If we allow passing any iterable we still need to do the conversion somewhere. Better to let the consumer handle it instead of the library. What do you think? |
I think the easiest way would be to just use built_collection throughout the framework. They are immutable and usually less error prone (immutable -> no side effects) |
Agreed, but I remember there was a problem when we used them in our parameters when we used BuiltList instead of List. I think it had something to do with default values 🤔 |
Agreed |
Makes it a bit easier to work with since List adds some unnecessary restrictions.
The text was updated successfully, but these errors were encountered: