Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize builtin storage wrappers #41119

Merged
merged 2 commits into from
Nov 8, 2023
Merged

optimize builtin storage wrappers #41119

merged 2 commits into from
Nov 8, 2023

Conversation

icewind1991
Copy link
Member

Mostly replacing $storage->instanceOfStorage with $mount instance which is significantly faster

@solracsf solracsf added this to the Nextcloud 28 milestone Oct 27, 2023
@icewind1991 icewind1991 force-pushed the optmize-storage-wrappers branch 3 times, most recently from 670c390 to 20ea66a Compare October 30, 2023 17:43
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
@icewind1991 icewind1991 force-pushed the optmize-storage-wrappers branch from 20ea66a to fe8cfe4 Compare November 1, 2023 13:17
@icewind1991 icewind1991 marked this pull request as ready for review November 2, 2023 13:21
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Nov 2, 2023
@icewind1991 icewind1991 requested review from a team, ArtificialOwl, nfebe, sorbaugh and come-nc and removed request for a team November 2, 2023 13:21
come-nc
come-nc approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, but looks sane.

@blizzz blizzz mentioned this pull request Nov 6, 2023
Merged
@icewind1991 icewind1991 mentioned this pull request Nov 8, 2023
Closed
@icewind1991 icewind1991 force-pushed the optmize-storage-wrappers branch from fe8cfe4 to 11ee868 Compare November 8, 2023 14:31
@icewind1991
Copy link
Member Author

merged #41056 into this due to the code overlap

@icewind1991
optimize isShared and isMounted
f4fa2fb 
Signed-off-by: Robin Appelman <[email protected]>
@icewind1991 icewind1991 force-pushed the optmize-storage-wrappers branch from 11ee868 to f4fa2fb Compare November 8, 2023 16:35
@icewind1991 icewind1991 merged commit b29bc59 into master Nov 8, 2023
49 checks passed
@icewind1991 icewind1991 deleted the optmize-storage-wrappers branch November 8, 2023 21:14
@icewind1991
Copy link
Member Author

/backport to stable27

@icewind1991
Copy link
Member Author

/backport to stable26

@AndyScherzinger
Copy link
Member

/backport to stable27

@AndyScherzinger
Copy link
Member

stable 26 has conflicts with the commits applied

@AndyScherzinger
Copy link
Member

stable 27 has conflicts with the commits applied

@icewind1991 icewind1991 mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
3. to review Waiting for reviews backport-request performance 🚀
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
4 participants
@icewind1991 @AndyScherzinger @come-nc @solracsf