Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications overview #988

Open
ShGKme opened this issue Dec 17, 2024 · 0 comments
Open

Notifications overview #988

ShGKme opened this issue Dec 17, 2024 · 0 comments

Comments

@ShGKme
Copy link
Contributor

ShGKme commented Dec 17, 2024

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Notifications reliability

Notifications are sometimes not reliable. Especially when an app is not used, notifications can be delayed and then many notifications shown simultaneously.

  1. Improve notifications logging
  2. Hypothesis 1 - Chromium suspends WS connection (most likely)
    • In this case we should move notifications handling to the main process in Talk Desktop
      • Make notify_push frontend environment independent
    • Alternative - Web Push API
  3. Hypothesis 2 - There is a problem with notify_push frontend
  4. Hypothesis 3 - There is a problem with notify_push backend

Notifications implementations

Currently Talk Desktop stores a copy of notifications app source code. This results in handling issues in 2 places.

  1. In the notifications app separate:
    • Notifications core (UI, web-browser, and Vue independent)
    • Talk related notifications handling
    • Frontend
  2. In the notifications app provide all above as a library and publish to npm
  3. Reuse in Talk Desktop

Notifications visibility

Currently notifications are only visible in the notifications center on the system level.

  1. Add Talk frontend API to get the number of unread messages as well as subscribe to an update
  2. Use this API to show the number in the badge
  3. Add UI to see the list of notifications

Other improvements

  • Update existing notification when possible:
    • Update notification text on the message edit
    • Remove notification when the message has been deleted
    • Replace "Incoming call" notification with "Missed call"
  • Make sure information from notifications, conversations list, and conversation are inline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant