Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions on smart picking #6817

Open
juliusknorr opened this issue Jan 2, 2025 · 5 comments · May be fixed by #6856
Open

Suggestions on smart picking #6817

juliusknorr opened this issue Jan 2, 2025 · 5 comments · May be fixed by #6856
Assignees
Labels
1. to develop enhancement New feature or request

Comments

@juliusknorr
Copy link
Member

We should provider users with more examples on what they can insert into a text document using the smart picker.

When discussing this with Jan, he mentioned squares as suggestions on what is possible to insert (like tiles in dashboard customization screen, with icons), and like Notion "Get started with". This will be a quick way to insert elements and to advertise the abilities of the smart picker more.

List of suggestions to start with:

  • Add image
  • Link to file or folder
  • Insert table
  • Smart picker

cc @jancborchardt

Design reference

Image Image
@juliusknorr juliusknorr added 1. to develop enhancement New feature or request labels Jan 2, 2025
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Jan 2, 2025
@juliusknorr juliusknorr moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 📝 Office team Jan 7, 2025
@JuliaKirschenheuter
Copy link
Contributor

Hi @marcoambrosini,

I have one question regarding:

Add image

What we have now:
Image

Which type should i implement as button inside of the editor?

Another question regarding "widgets". I've asked Jan and he confirmed would be better to implement buttons this way:

Image

@juliusknorr
Copy link
Member Author

Discussion from the team call:

  • We hide this as soon as there is some content on the page
  • We call it "Upload image or file" and use the os file picker (as "Upload form computer" from the menu)
  • We start with 4 buttons only
  • To clarify with @jancborchardt

@jancborchardt
Copy link
Member

@juliusknorr of course it would be nice to have the "More smart picker" 3-dot button as well at some point, but yes we can first start with some essentials. :)

@marcoambrosini marcoambrosini moved this from 📐 At design to 🏗️ At engineering in 🖍 Design team Jan 13, 2025
@JuliaKirschenheuter JuliaKirschenheuter linked a pull request Jan 15, 2025 that will close this issue
@JuliaKirschenheuter
Copy link
Contributor

Hi @marcoambrosini

We call it "Upload image or file" and use the os file picker (as "Upload form computer" from the menu)

Ok, this one "upload from computer" is implemented. This is actually the same function as "Link to file or folder", we don't have a function only for "add Image". What should i place instead / or replace it with some other button?

@JuliaKirschenheuter
Copy link
Contributor

Second thing: we have a smart picker dialog, which looks like this:

Image

It is implemented now under "smart picker" button. Is it what we want to have?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop enhancement New feature or request
Projects
Status: 📄 To do (~10 entries)
Status: 🏗️ At engineering
Development

Successfully merging a pull request may close this issue.

3 participants