Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validate phone number #394

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: validate phone number #394

wants to merge 5 commits into from
+402 −4

Conversation

kobenguyent
Copy link
Contributor

@kobenguyent kobenguyent commented Jan 8, 2025 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

the numbers generated are at risk of not being actually valid phone numbers.

What is the new behavior?

  • validate the phone number to make sure it's valid using phone library.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@stackblitz StackBlitz
Copy link

stackblitz bot commented Jan 8, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@NetanelBasal
Copy link
Member

test is stuck

@kobenguyent
Copy link
Contributor Author

Unfortunately, yes. Need to think of a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

randPhoneNumber will generate invalid US phone numbers
2 participants
@kobenguyent @NetanelBasal