Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should support appProtocol http #572

Open
ryanobjc opened this issue Jan 14, 2025 · 0 comments
Open

Should support appProtocol http #572

ryanobjc opened this issue Jan 14, 2025 · 0 comments
Labels
area/controller Issues dealing with the controller bug Something isn't working needs-triage Issues that need triage

Comments

@ryanobjc
Copy link

Kubernetes Version

v1.29.3+orb1

Helm Chart Version

ngrok-ingress-controller ngrok-system 4 2025-01-14 15:34:51.501113 -0800 PST deployed kubernetes-ingress-controller-0.15.0 0.12.2

Operator Configuration

n/a

System Info

Darwin mm.local 24.1.0 Darwin Kernel Version 24.1.0: Thu Oct 10 21:03:11 PDT 2024; root:xnu-11215.41.3~2/RELEASE_ARM64_T6020 arm64

Kubernetes Logs

{"level":"info","ts":"2025-01-14T23:36:10Z","msg":"Starting workers","controller":"gateway","controllerGroup":"gateway.networking.k8s.io","controllerKind":"Gateway","worker count":1}
{"level":"info","ts":"2025-01-14T23:36:10Z","logger":"cache-store-driver","msg":"sync start"}
{"level":"info","ts":"2025-01-14T23:36:10Z","logger":"cache-store-driver","msg":"syncing driver state!!"}
{"level":"error","ts":"2025-01-14T23:36:10Z","logger":"cache-store-driver","msg":"could not find port for service","namespace":"test","service":"dwn","error":"unsupported appProtocol: 'http', must be 'k8s.ngrok.com/http2', 'kubernetes.io/h2c' or ''. From: test service: dwn","stacktrace":"github.com/ngrok/kubernetes-ingress-controller/internal/store.(*Driver).calculateTunnelsFromGateway\n\tgithub.com/ngrok/kubernetes-ingress-controller/internal/store/driver.go:1634\ngithub.com/ngrok/kubernetes-ingress-controller/internal/store.(*Driver).calculateTunnels\n\tgithub.com/ngrok/kubernetes-ingress-controller/internal/store/driver.go:1551\ngithub.com/ngrok/kubernetes-ingress-controller/internal/store.(*Driver).Sync\n\tgithub.com/ngrok/kubernetes-ingress-controller/internal/store/driver.go:428\ngithub.com/ngrok/kubernetes-ingress-controller/internal/controller/gateway.(*HTTPRouteReconciler).Reconcile\n\tgithub.com/ngrok/kubernetes-ingress-controller/internal/controller/gateway/httproute_controller.go:109\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\tsigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:119\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\tsigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:316\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\tsigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\tsigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:227"}
{"level":"info","ts":"2025-01-14T23:36:10Z","logger":"cache-store-driver","msg":"sync done"}

Helm Chart configuration

No response

What happened

My service uses appProtocol: http - because it does use http, but I guess ngrok doesn't like http backend?

In this case, our manifests originally run on istio, but in our test environment we are using ngrok, but it seems like we will have to deviate because of this bug.

What you think should happen instead

Ngrok supports http backends, that it fails on an appProtocol: http doesn't seem conforming.

How to reproduce

No response

@ryanobjc ryanobjc added area/controller Issues dealing with the controller bug Something isn't working needs-triage Issues that need triage labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller Issues dealing with the controller bug Something isn't working needs-triage Issues that need triage
Projects
None yet
Development

No branches or pull requests

1 participant