Fix / re-evaluate Blazor disabled code analysis rules #2453
Labels
Comments
This was referenced Oct 28, 2024
Closed
rajsite
pushed a commit
that referenced
this issue
Nov 1, 2024
# Pull Request ## 🤨 Rationale Resolves #1667 - Split off resolving more code analysis suppressions to #2453 - #2355 : Resolved by updates to Nimble/Spright JS initialization scripts for .NET 8 - #2188 : Not reproducible by Nimble team, can debug further once changes published if client can still reproduce ## 👩💻 Implementation - Projects in Blazor solution now target `net8.0` (formerly `net6.0`) - Update other .NET dependencies, and code analyzer package versions - Update docs - Re-build `Demo.Server` example based on new Blazor Web App template - Update acceptance test projects to use similar setup as Blazor Web App templates - `NimbleBlazor.Tests.Acceptance.Client`: Existing tests use the `InteractiveServer` render mode. The project also now supports tests using `InteractiveWebAssembly` and static SSR render modes. Add one example test for each. - TODO: Spright acceptance test project currently don't use the new setup yet. If the changes look reasonable and we want to do the same for the Spright tests, I can do so in an update. ## 🧪 Testing - Manual testing - Autotests (unit/acceptance) pass. New tests for Nimble for InteractiveWebAssembly / static SSR render modes. ## ✅ Checklist - [x] I have updated the project documentation to reflect my changes or determined no changes are needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🧹 Tech Debt
Currently we have a decent number of disabled code analysis rules on our Blazor solution, accrued over time (with analyzer package updates / .NET updates). We should do a pass over them and see which can be easily fixed / re-enabled.
The bulk of these are in
blazor-workspace\.editorconfig, but there's also a few in the individual.csprojfiles to evaluate too.The text was updated successfully, but these errors were encountered: