Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for skipping hidden rows #749

Open
1 task done
spokelsedis opened this issue Jun 14, 2023 · 2 comments
Open
1 task done

Support for skipping hidden rows #749

spokelsedis opened this issue Jun 14, 2023 · 2 comments

Comments

@spokelsedis
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

As far as I can tell, this library doesn't have any support for reading if a row is hidden or not.

Expected Behavior

I have some sheets that I'd like to skip reading any hidden rows. It would be useful to either:

  • Add an option to skip reading hidden rows
  • Expose an is_row_hidden field, then I could filter out any rows with is_row_hidden = True

Steps To Reproduce

No response

Environment

- Spark version:
- Spark-Excel version:
- OS:
- Cluster environment

Anything else?

It looks like the Apache POI library supports reading hidden attributes, at least for cells/sheets (see https://github.com/apache/poi/blob/6943cc9a9c8528ca47bba2a499e408e41f0c893e/poi/src/main/java/org/apache/poi/hssf/record/BoundSheetRecord.java#L158).

@nightscape
Copy link
Owner

That would be a nice contribution, we're open to PRs 👍

@macsj200
Copy link

@nightscape I have a draft PR here: #817

Please let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants