Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify how settings are stored #361

Closed
DreyCon-Raphael opened this issue Jul 25, 2024 · 1 comment
Closed

Unify how settings are stored #361

DreyCon-Raphael opened this issue Jul 25, 2024 · 1 comment
Labels
enhancement New feature or request needs-triage

Comments

@DreyCon-Raphael
Copy link

DreyCon-Raphael commented Jul 25, 2024

Is your feature request related to a problem? Please describe.

When editing settings in Trio subviews behave differently.

Some settings are stored and activated immediatle (I) by leaving the edit field, others need to be saved by pushing a button (B).

settings view storing behavior
Preferences (I)
Pump Settings (B)**
Meal Settings (I)
Basal Profile (B)**
Insulin Sensitivity (B)*
Carb Ratios (B)*
Target Glucose (B)*
Autotune (B)***
  • (I) is stored immediately
  • * ist stored via a button labeled "Save"
  • ** is stored via a button called "Save on Pump"
  • *** is stored via a button called "Save as your Normal Basal Rates"

Despite that this is only a UX thing, I suggest to unify this to always have a save button. This could also be used as a hook to push the new changes to NS.

Describe the solution you'd like

  1. Use the same save button everywhere
  • regardless of whether values are stored
    • only in app for "cosmetically" changes (e.g.: hours displayed on home view)
    • for basic pump behaviour (e.g. offline basal rates) or
    • for oref's needs (e.g. ISF, CR)
  1. prepare a hook for pushing changes to NS with a "valid from" timestamp
  2. (optional) ask for individual notes to the made changes (such as an optional commit message). Users can rethink decisions made based on their notes.

Additional context

Save on Pump
image
Save
image
Save as your Normal Basal Rates
image

Technical Details

User Impact

  • Needs the User to ALWAYS hit a save button for changes to take effect.
  • Enables the user to discard changes made if not having previous values noted anywhere
  • Enables storing history of changes made
@dnzxy
Copy link
Contributor

dnzxy commented Jul 26, 2024

Duplicate of #98. Closing.

@dnzxy dnzxy closed this as completed Jul 26, 2024
@github-project-automation github-project-automation bot moved this to Done in Trio Jul 26, 2024
mountrcg pushed a commit to mountrcg/Trio that referenced this issue Aug 1, 2024
Now saves both real dates of meals and the date of creation. 
Health store issue is only partly fixed. Will continue with this later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-triage
Projects
Status: Done
Development

No branches or pull requests

2 participants