rework the vtable implementation embedding the vtable array directly with new strictions on methods #22991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2101d30.
Co-authored-by: Andreas Rumpf <[email protected]>
2 tasks
ringabout
changed the title
|
Merging for now but it needs to be behind |
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
1 task
Araq
added a commit
that referenced
this pull request
Nov 30, 2023
…ure (#23004) follow up #22991 - [x] turning it into an experimental feature --------- Co-authored-by: Andreas Rumpf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
fixes changelog
With the new option
nimPreviewVtables,methodsare confined in the same module where the type of the first parameter is definedmake it opt in after CI checks its feasibility
In the following-up PRs
in the following PRs, refactor code into a more efficient one
cpp needs special treatments since it cannot embed array in light of the preceding limits: ref replace data init function with consts for typeinfov2 #20977 (comment); we can support cpp backends with vtable implementations later on the comprise that uses indirect vtable access