Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #22923; fixes =dup issues #23182

Merged
merged 2 commits into from
Jan 11, 2024
Merged

fixes #22923; fixes =dup issues #23182

merged 2 commits into from
Jan 11, 2024

Conversation

ringabout
Copy link
Member

fixes #22923

@ringabout ringabout marked this pull request as ready for review January 9, 2024 14:38
@ringabout
Copy link
Member Author

The =dup raising unlisted Exception Exception seems to be the same issue of #23129, I will fix it later

@ringabout ringabout changed the title fixes #22923; fixes arraywith fixes #22923; fixes =dup issues Jan 9, 2024
ringabout
ringabout commented Jan 9, 2024
View reviewed changes
lib/system.nim Outdated Show resolved Hide resolved
@Araq Araq merged commit 29ac3c9 into devel Jan 11, 2024
22 checks passed
@Araq Araq deleted the pr_with_array branch January 11, 2024 10:23
@github-actions GitHub Actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 29ac3c9

Hint: mm: orc; opt: speed; options: -d:release
177720 lines; 7.682s; 767.688MiB peakmem

narimiran pushed a commit that referenced this pull request Apr 19, 2024
@ringabout @narimiran
fixes #22923; fixes =dup issues (#23182)
7916210 
fixes #22923

(cherry picked from commit 29ac3c9)
narimiran pushed a commit that referenced this pull request Apr 20, 2024
@ringabout @narimiran
fixes #22923; fixes =dup issues (#23182)
a46f157 
fixes #22923

(cherry picked from commit 29ac3c9)
narimiran pushed a commit that referenced this pull request Apr 20, 2024
@ringabout @narimiran
fixes #22923; fixes =dup issues (#23182)
fbb9ce4 
fixes #22923

(cherry picked from commit 29ac3c9)
narimiran added a commit that referenced this pull request Apr 23, 2024
@narimiran
Revert "fixes #22923; fixes =dup issues (#23182)"
33817f2 
This reverts commit fbb9ce4.
@narimiran narimiran mentioned this pull request Apr 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: internal error: genMagicExpr: mDup when using arrayWith with some types.
2 participants
@ringabout @Araq