Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the plugin compatbile with the latest release of keel #106

Open
nabuskey opened this issue Apr 7, 2022 · 2 comments
Open

make the plugin compatbile with the latest release of keel #106

nabuskey opened this issue Apr 7, 2022 · 2 comments

Comments

@nabuskey
Copy link
Collaborator

nabuskey commented Apr 7, 2022

Due to the upstream API changes introduced in the latest release of Keel, some classes in this plugin need to change to implement them. Mostly around artifact handing.

@JonGilmore
Copy link
Contributor

I'm curious on your thoughts on this - how about we try to move this plugin to the upstream repo? This implementation is clean enough that it probably wouldnt be too tough to do, AND we wouldn't hit these types of issues in the future.
Thoughts??

@nimakaviani
Copy link
Owner

interesting idea.

Initially, the reason we built the k8s integration into a plugin was to manage its maintainability and release cadence independent of the upstream work. Since less of the upstream work is happening lately, those motivations are not relevant anymore.

But at the same time, there hasn't been much change to the base code of keel either, unless the spinnaker community picks up that line of work again. The way things stand, I am unsure how the OSS work for spinnaker will evolve.

I am inclined to say let's wait on merging the two code bases and see which direction keel and spinnaker take. we can decide then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants