You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Due to the upstream API changes introduced in the latest release of Keel, some classes in this plugin need to change to implement them. Mostly around artifact handing.
The text was updated successfully, but these errors were encountered:
I'm curious on your thoughts on this - how about we try to move this plugin to the upstream repo? This implementation is clean enough that it probably wouldnt be too tough to do, AND we wouldn't hit these types of issues in the future.
Thoughts??
Initially, the reason we built the k8s integration into a plugin was to manage its maintainability and release cadence independent of the upstream work. Since less of the upstream work is happening lately, those motivations are not relevant anymore.
But at the same time, there hasn't been much change to the base code of keel either, unless the spinnaker community picks up that line of work again. The way things stand, I am unsure how the OSS work for spinnaker will evolve.
I am inclined to say let's wait on merging the two code bases and see which direction keel and spinnaker take. we can decide then.
Due to the upstream API changes introduced in the latest release of Keel, some classes in this plugin need to change to implement them. Mostly around artifact handing.
The text was updated successfully, but these errors were encountered: