Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift-Enter & Alt-R only works when focusing the code editor #52

Open
syimyuzya opened this issue Nov 24, 2024 · 2 comments
Open

Shift-Enter & Alt-R only works when focusing the code editor #52

syimyuzya opened this issue Nov 24, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@syimyuzya
Copy link
Member

syimyuzya commented Nov 24, 2024

Which makes this hotkey far less useful.

NOTE: The code editor is NEVER the main purpose of the GUI. Don't prioritize it over the ARTICLE/OPTIONS part.

@graphemecluster
Copy link
Member

我已經在使用説明中註明,但我也覺得這是個問題
跟推導結果改用 <dialog> 一樣,我是認為 shortcut 這種輪子不應該自己實現纔這樣改的
(附帶一提,而且這樣 shortcut 會顯示在 command palette 中~)

用其他 library 也不是不行,只是我覺得既然 monaco-editor 已經有這個機制,不想多一個其他 library 的機制蓋過它
讓我看看 VSCode 是怎麼實現不 focus editor 也能 trigger shortcut 的~

@syimyuzya
Copy link
Member Author

syimyuzya commented Nov 24, 2024

(附帶一提,而且這樣 shortcut 會顯示在 command palette 中~)

好耶~

不過我看了下,其他快速鍵都至少和「編輯」方案的行為有關,但「執行推導」卻與此並無關聯,而且實際代碼也確實沒給它定義 command 名稱。

所以「執行推導」這動作本來也不「附屬」於編輯器(甚至地位高於編輯器),讓整個 app 的核心行為去遷就編輯器的 API 就更是本末倒置了😂

@ayaka14732 ayaka14732 added the enhancement New feature or request label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants