Replies: 2 comments 1 reply
-
All these suggestions sound good to me! One thing that I've been most interested in is to decompose the |
Beta Was this translation helpful? Give feedback.
-
I cleaned up the interception logic. All test passes (https://github.com/nock/nock/tree/Michael/cleanup) Maybe I'll do this in the next beta branch.. for maximum visibility.. although these are a lot of changes. I documented all breaking changes, ideas, and regressions (that I'll fix) in the |
Beta Was this translation helpful? Give feedback.
-
Hey team :)
In Nock v14, we moved the interception logic to
@mswjs/interceptors
. Because this was a fundamental change, we aimed to minimize modifications to the behavior and the underlying code. This decision meant we had to retain some legacy code and functionality for another major version.While I'm excited to implement new features such as undici support, history, and OpenAPI integration, websockets?, among others—this is a great opportunity to refresh and modernize the repository. We could consider enhancements like:
no match
event that transmits the same arguments.Request
object rather than justoptions
in our events and functions.this.req
(code).And likely even more improvements.
My main concern is ensuring we don’t create an overwhelming burden for users migrating from v14 to the next major version. Also, if you have any other suggestions for enhancements, I’d love to hear them!
CC @nock/maintainers
Beta Was this translation helpful? Give feedback.
All reactions