Signature and Time incorrectly has their prototype methods flagged as instance variables

[rcjsuen]

If you look at the online documentation for Signature and Time, you will see that both types have a few instance variables. However, if you look at the actual generated signature.cc and time.cc files, you will see that those are actually prototype methods and not instance variables defined on the JavaScript object.

[saper]

This belongs to the doc repository and is somehow related to the way instance variables are detected (in my opinion this is also related to nodegit/nodegit.github.com#46)

[rcjsuen]

The generated output is in the doc repository but I think the issue is that the input in libgit2-docs.json is flagging those things as instance variables.

      "git_signature",
      {
        "decl": [
          "char * name",
          "char * email",
          "git_time when"
        ],

      "git_time",
      {
        "decl": [
          "git_time_t time",
          "int offset"
        ],

[saper]

maybe, you seem to know more than I do :)

[jmtoball]

Any news on this? I assume the type definitions here are also generated from the documentation and that makes working with nodegit in TypeScript a bit cumbersome 😩

The (assumed) underlying issue is not exclusive to Signature either. The methods on BlameHunk also documented as fields.