Memory leak in 1-getting-started/6_object_wrap ?

[graebm]

node-addon-examples/src/1-getting-started/6_object_wrap/napi/myobject.cc

Lines 103 to 111 in 59cb03a

	MyObject* obj = new MyObject(value);
	obj->env_ = env;
	status = napi_wrap(env,
	jsthis,
	reinterpret_cast<void*>(obj),
	MyObject::Destructor,
	nullptr, // finalize_hint
	&obj->wrapper_);

The code above allocates memory for MyObject via new (which allocates and calls MyObject::MyObject()), but I don't see where that memory is ever freed?

Here's the finalizer...

node-addon-examples/src/1-getting-started/6_object_wrap/napi/myobject.cc

Lines 11 to 15 in 59cb03a

	void MyObject::Destructor(napi_env env,
	void* nativeObject,
	void* /*finalize_hint*/) {
	reinterpret_cast<MyObject*>(nativeObject)->~MyObject();
	}

I believe that finalizer code should be like:

  MyObject* obj = reinterpret_cast<MyObject*>(nativeObject);
  delete obj;

delete will call MyObject::~MyObject() AND free the memory

[mhdawson]

@graebm, we discussed in the node-api team meeting today and agree the example should use delete instead of calling ~MyObject(). Would you like to submit a PR to fix that?