Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add U240 params #83

Open
olehmisar opened this issue Dec 20, 2024 · 3 comments
Open

Add U240 params #83

olehmisar opened this issue Dec 20, 2024 · 3 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@olehmisar
Copy link
Contributor

Problem

U240 would be enough for most EVM token amount operations, so in Noir it can be represented with only 2 limbs (vs 3 limbs for U256).

Happy Case

Implement bignum::fields::U240Params

Workaround

None

Workaround Description

No response

Additional Context

No response

Project Impact

Nice-to-have

Blocker Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@olehmisar olehmisar added the enhancement New feature or request label Dec 20, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Dec 20, 2024
@olehmisar
Copy link
Contributor Author

also, would be interesting to see the benchmarks of std::U128 vs bignum::U240 as they both consist of 2 limbs(except U128 limbs are of type u64)

@TomAFrench
Copy link
Member

Hey, before adding this we would want to see the outcomes of the token standardization work to determine whether U240 would actually be used.

Until that point, it can be instantiated outside of this library.

@Savio-Sou Savio-Sou added the question Further information is requested label Jan 23, 2025
@olehmisar
Copy link
Contributor Author

@TomAFrench how do I get the U240 parameters? Also, I need U253 parameters as well for the benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
Status: 📋 Backlog
Development

No branches or pull requests

5 participants