Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QTS breaks my permalink structure #130

Open
aga-parts opened this issue Feb 28, 2017 · 4 comments
Open

QTS breaks my permalink structure #130

aga-parts opened this issue Feb 28, 2017 · 4 comments

Comments

@aga-parts
Copy link

I can't activate QTS or many of my exisiting permalinks break.

Anything that looks like http://domain.com/parentPageA/childPage breaks if there is one or more http://domain.com/parentPageB/childPage pages where the childePage component is an equal string across. I have hundreds of pages with this structure so the puglin is unsuable unless I go thorugh each page and Update with new slugs manually. Even then the permalinks won't work when typed directly into the browser, or if there are existing backlinks into the site. Note: Problem does NOT occur accross translations.

    - http://domain.com/lang/parentPageA/childPage -> Content1
    - http://domain.com/lang/parentPageB/childPage -> Content1 (should be Content2)
    - http://domain.com/parentPageA/childPage -> Content3
    - http://domain.com/parentPageB/childPage -> Content3 (should be Content4)

If anything please someone point me in the right direction to fix the rewrite rules myself.

@LC43
Copy link
Collaborator

LC43 commented Feb 28, 2017

i assume you created these subpages before using qts right? because the plugin tries to make the slugs unique.

before fixing this, fixing #12 would have to happen first. And then, check if the path is unique before trying to make the slug unique.

It would then fill the qts fields automatically.

Open Question: what you expect to happen in this scenario where the qts slugs where to be updated automatically?

suggestion 1: append the language code

  • path1/page-fi
  • path1/page-ma

suggestion 2: append numeral for each language.

  • path1/page-1
  • path1/page-2

other?

@aga-parts
Copy link
Author

@LC43

The two options that would make sense would be to append the language code or use titles by language.
This could be a series of options.

  • Append language codes VS Use Titles (Choose one)
  • Don't affect default language permalinks (Check).
    • I'm interested highly in this due to SEO.
    • If Append language codes is the chosen options, then default language wouldn't have any suffix.
    • If Using Titles is chosen, keep original permalink for default language as opposed to using its title.

@aga-parts
Copy link
Author

@LC43 Is there a way for us to contact each other directly? I'd like to speak about the time-line for implementing this or guidance for me to fix it and to a Pull Request. Don't know if you, uh, do expedited open source codebase maintenance. I need a fix asap.

@LC43
Copy link
Collaborator

LC43 commented Feb 28, 2017

i'm usually at the wordpress slash, lurking in #core as pcarvalho. do you use slack @aga-parts ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants