Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to use plugins to import certificates (and maybe trust policies) #902

Open
tomaszkrzyzanowski opened this issue Mar 4, 2024 · 5 comments
Assignees
Labels
duplicate This issue or pull request already exists enhancement New feature or request spec Specifications to define the product requirements v2 Things belongs to version 2.x
Milestone

Comments

@tomaszkrzyzanowski
Copy link

Is your feature request related to a problem?

I'd like to implement verification workflow based on Hashicorp Vault similarly to how it's possible to implement signing workflow with the plugin.

I'm going to perform verification on CI/CD ephemeral runners and I need a method to fetch the verification certificate.

What solution do you propose?

I'd like to extend the notation certificate add command with --plugin and --id option to support fetching the verification certificate from KV store like HC Vault

What alternatives have you considered?

  1. Extend hc-vault's key-helper to add fetch option
  2. Write shell scripts to cover fetching importing the key

Any additional context?

Vault is used to store the certificates(in kv) and key (in transit), so it seems natural for me to use it as a source of true for obtaining the certificates.

If you find that valuable, I can try to send the PR's to repositories with appropriate changes.

@tomaszkrzyzanowski tomaszkrzyzanowski added enhancement New feature or request triage Need to triage labels Mar 4, 2024
@yizha1 yizha1 added this to the 1.3.0 milestone Mar 6, 2024
@yizha1 yizha1 removed the triage Need to triage label Mar 6, 2024
@FeynmanZhou
Copy link
Member

This is a good proposal which will simplify importing root certs for verification. I had a similar feature request in #631

@JeyJeyGao
Copy link
Contributor

It is a good idea to simplify the certificate installation process. Usually, the key vault supports signing and also stores the certificate. Therefore, if the plugin provides the ability to download the root certificate, it would be easier for the user. To achieve this goal, we need to extend the plugin protocol to support a certificate fetching operation.

@yizha1 yizha1 modified the milestones: 1.3.0, Future Dec 3, 2024
@yizha1 yizha1 added the v2 Things belongs to version 2.x label Dec 3, 2024
@yizha1
Copy link
Contributor

yizha1 commented Dec 3, 2024

@tomaszkrzyzanowski would you like to work on this issue?

@yizha1 yizha1 added spec Specifications to define the product requirements duplicate This issue or pull request already exists labels Dec 3, 2024
@tomaszkrzyzanowski
Copy link
Author

@yizha1 sure, why not :) I should have some time around 3 week of the Dec, I will try to prepare something

@yizha1
Copy link
Contributor

yizha1 commented Dec 4, 2024

Great and Thank you @tomaszkrzyzanowski . I will assign this issue to you, and we can decide the milestone later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request spec Specifications to define the product requirements v2 Things belongs to version 2.x
Projects
Status: Todo
Development

No branches or pull requests

4 participants