Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: Network magic field is never set #671

Open
cthulhu-rider opened this issue Dec 16, 2024 · 0 comments
Open

client: Network magic field is never set #671

cthulhu-rider opened this issue Dec 16, 2024 · 0 comments
Labels
bug Something isn't working client Issue related to the client I4 No visible changes S4 Routine U3 Regular
Milestone

Comments

@cthulhu-rider
Copy link
Contributor

https://github.com/nspcc-dev/neofs-api/blob/e66b25d4bf2afc4472023e1e2c2467f694f5a0e1/session/types.proto#L186

Current Behavior

Client never sets it

Expected Behavior

the field is set

Possible Solution

Provide init prm for it and send

Context

since there are no errors, servers do not check it

Regression

no i guess

Your Environment

  • Version of the product used: 0b9bb74
@cthulhu-rider cthulhu-rider added bug Something isn't working client Issue related to the client labels Dec 16, 2024
@roman-khimov roman-khimov added U3 Regular S4 Routine I4 No visible changes labels Dec 16, 2024
@roman-khimov roman-khimov added this to the v1.0.0-rc13 milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client Issue related to the client I4 No visible changes S4 Routine U3 Regular
Projects
None yet
Development

No branches or pull requests

2 participants